New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc e2e test fixes #44325
Misc e2e test fixes #44325
Conversation
Hi , @woocommerce/solaris, @woocommerce/vortex Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 6427d14
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, I only left one comment for the workers update as I'm not sure you meant to push that change.
* Change local workers to 1 * Add helpers for adding shipping * Add shipping zone before order * Fix tax assertion * Fix assertion * Tightened up locators * Dismiss tour if visible * Back to function * Update tax label * Enable shipping * Update locator * Changelog --------- Co-authored-by: Jon Lane <jon.lane@automattic.com>
Submission Review Guidelines:
Changes proposed in this Pull Request:
There's a number of tests that have become flaky recently. Here's some fixes.
Closes #44060
Closes #44059
Closes #44172
Closes #44252
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment