Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc e2e test fixes #44325

Merged
merged 12 commits into from Feb 2, 2024
Merged

Misc e2e test fixes #44325

merged 12 commits into from Feb 2, 2024

Conversation

lanej0
Copy link
Contributor

@lanej0 lanej0 commented Feb 2, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

There's a number of tests that have become flaky recently. Here's some fixes.

Closes #44060
Closes #44059
Closes #44172
Closes #44252

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure CI passes

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@lanej0 lanej0 added the focus: e2e tests Issues related to e2e tests label Feb 2, 2024
@lanej0 lanej0 requested review from a team February 2, 2024 17:20
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Hi , @woocommerce/solaris, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Test Results Summary

Commit SHA: 6427d14

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests273003603096m 40s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@adimoldovan adimoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I only left one comment for the workers update as I'm not sure you meant to push that change.

@lanej0 lanej0 merged commit f93dcc2 into trunk Feb 2, 2024
40 of 41 checks passed
@lanej0 lanej0 deleted the fix/e2e-test-fixes branch February 2, 2024 18:17
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 2, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 2, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 5, 2024
samueljseay pushed a commit that referenced this pull request Feb 6, 2024
* Change local workers to 1

* Add helpers for adding shipping

* Add shipping zone before order

* Fix tax assertion

* Fix assertion

* Tightened up locators

* Dismiss tour if visible

* Back to function

* Update tax label

* Enable shipping

* Update locator

* Changelog

---------

Co-authored-by: Jon Lane <jon.lane@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
3 participants