Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Enforce style on express checkout buttons #44346

Draft
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

tarunvijwani
Copy link
Contributor

@tarunvijwani tarunvijwani commented Feb 5, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

P2 Post: pdFofs-1O1-p2

This is POC PR to demonstrate limited control over the express checkout buttons using the wrapper component.

In this PR, we're enforcing the style on express checkout buttons. If there are two express checkout buttons, it will display them in a single column instead of the single row.

The branch is based on #44346 PR branch.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Activate the Stripe plugin and enable express payment options.
  2. Activate the PayPal payment plugin and enable express payment options.
  3. Add a product to the Cart and visit the Checkout block page with https.
  4. Confirm the below express payment buttons is displayed in a single column:
    image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test Results Summary

Commit SHA: af39033

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests304001303177m 20s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@tarunvijwani tarunvijwani self-assigned this Feb 7, 2024
@tarunvijwani tarunvijwani changed the title Add ExpressPaymentButtonWrapper component to ExpressPaymentMethods [POC] Add ExpressPaymentButtonWrapper component to ExpressPaymentMethods Feb 12, 2024
@tarunvijwani tarunvijwani changed the title [POC] Add ExpressPaymentButtonWrapper component to ExpressPaymentMethods [POC] Enforce style on express checkout buttons Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant