Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS - Core] Before installing the fonts, ensure that the font library is available #44358

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Feb 5, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR introduces a check to ensure that the Font Library is installed before proceeding with the font installation.

Closes #44315 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new WooCommerce installation with this version.
  2. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  3. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  4. Install this build of Gutenberg that contains the new Font Library API:
    gutenberg.zip
  5. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  6. Open the network tools.
  7. Follow the process.
  8. Ensure that there are some requests to /font-face and /font-families endpoints.
  9. Uninstall Gutenberg.
  10. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  11. Follow the process.
  12. Open the network tools.
  13. Ensure there are no request to /font-face and /font-families endpoints.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

[CYS - Core]: Before installing the fonts, ensure that the font library is available

Comment

@gigitux gigitux added team: Kirigami & Origami focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Feb 5, 2024
@gigitux gigitux self-assigned this Feb 5, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Hi @albarin, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

…-cys-core-before-installing-the-fonts-ensure-that-the-font-library-is-available
@github-actions github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test Results Summary

Commit SHA: 814dffd

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests287002203096m 38s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin
Copy link
Contributor

albarin commented Feb 5, 2024

@gigitux

Ensure that there are some requests to /font-face and font-family endpoints.

I'm not seeing those requests, this is what I'm seeing, is it expected?

  • With Gutenberg enabled:
Screenshot 2024-02-05 at 16 42 22
  • Without Gutenberg:
Screenshot 2024-02-05 at 16 43 53

@gigitux
Copy link
Contributor Author

gigitux commented Feb 5, 2024

I updated the description. There was a typo, the right endpoint is /font-families. You don't see any request to font-face because you already have installed the font faces.

If you want to test the full flow, you have to remove all the wp_font_family and wp_font_face post_type and you should see more requests.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 6, 2024
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@gigitux gigitux merged commit 159d474 into trunk Feb 6, 2024
30 checks passed
@gigitux gigitux deleted the 44315-cys-core-before-installing-the-fonts-ensure-that-the-font-library-is-available branch February 6, 2024 10:28
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 6, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 6, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CYS - Core: before installing the fonts, ensure that the font library is available
3 participants