New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS - Core] Before installing the fonts, ensure that the font library is available #44358
[CYS - Core] Before installing the fonts, ensure that the font library is available #44358
Conversation
…used also in other places Refactor, add comments and cleanup
…esign step to avoid having to fetch it again
…erce/woocommerce into 44315-cys-core-before-installing-the-fonts-ensure-that-the-font-library-is-available
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
…-cys-core-before-installing-the-fonts-ensure-that-the-font-library-is-available
Test Results SummaryCommit SHA: 814dffd
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
I updated the description. There was a typo, the right endpoint is If you want to test the full flow, you have to remove all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR introduces a check to ensure that the Font Library is installed before proceeding with the font installation.
Closes #44315 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.gutenberg.zip
wp-admin/admin.php?page=wc-admin&path=/customize-store
./font-face
and/font-families
endpoints.wp-admin/admin.php?page=wc-admin&path=/customize-store
./font-face
and/font-families
endpoints.Changelog entry
Significance
Type
Message
[CYS - Core]: Before installing the fonts, ensure that the font library is available
Comment