Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve existing E2E shopper product description & images test #44365

Merged
merged 2 commits into from Feb 7, 2024

Conversation

veljkho
Copy link
Contributor

@veljkho veljkho commented Feb 5, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Improves already closed # 676 in Woo Quality

This is a follow-up PR to improve the existing E2E test as part of the existing project to enhance e2e tests. This is more of a leftover change from previous improvement.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Check this branch
  2. Execute locally: pnpm test:e2e-pw ./tests/e2e-pw/tests/shopper/product-simple.spec.js
  3. Make sure CI passes

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@veljkho veljkho self-assigned this Feb 5, 2024
@veljkho veljkho added the focus: e2e tests Issues related to e2e tests label Feb 5, 2024
@veljkho veljkho changed the title Improve existing simple product test Improve existing E2E test Shopper > Simple Product > Description & Product Images Feb 5, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test Results Summary

Commit SHA: 528f560

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests259005003098m 10s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@veljkho veljkho changed the title Improve existing E2E test Shopper > Simple Product > Description & Product Images Improve existing E2E shopper product description & images test Feb 5, 2024
@veljkho veljkho requested a review from a team February 5, 2024 15:56
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Hi @alvarothomas, @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@alvarothomas alvarothomas requested review from alvarothomas and removed request for a team February 6, 2024 18:04
Copy link
Contributor

@alvarothomas alvarothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring this and improving the tests. The changes make them look better and all tests are passing.

@veljkho veljkho merged commit 28bfa54 into trunk Feb 7, 2024
35 checks passed
@veljkho veljkho deleted the e2e/update/shopper-simple-product-images branch February 7, 2024 10:33
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 7, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 7, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants