[e2e] Can Edit and Delete Product Review

[alvarothomas]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/woocommerce-quality/issues/610

Closes https://github.com/woocommerce/woocommerce-quality/issues/611

The tests focus on editing and deleting product reviews, verifying the visibility of review elements in the admin interface as a merchant.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Code review.
2. Verify if there are any additional steps or assertions that need to be included
3. Run pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/product-reviews.spec.js --headed and make sure that all the tests are passing.
4. CI jobs should be green.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Add e2e tests to edit and delete product reviews.

Comment

[github-actions]

Hi @adimoldovan, @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: 83067ef

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	288	0	0	29	0	317	5m 40s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[adimoldovan]

Hi @alvarothomas, thanks for working on this.

The problem I see with this spec is that all 3 tests are using the same product, and if they are to run in parallel they will impact each other. The delete test will probably delete the review and the other 2 tests will fail.
Each test should be independent, and have its own test data. I would suggest to either use a beforeEach, that will create a product before each test instead of a single product beforeAll, or use a fixture, that will isolate the data for each test. Here's an example of a product fixture.

[alvarothomas]

Hi @alvarothomas, thanks for working on this.

The problem I see with this spec is that all 3 tests are using the same product, and if they are to run in parallel they will impact each other. The delete test will probably delete the review and the other 2 tests will fail. Each test should be independent, and have its own test data. I would suggest to either use a beforeEach, that will create a product before each test instead of a single product beforeAll, or use a fixture, that will isolate the data for each test. Here's an example of a product fixture.

That's a very good point, @adimoldovan . Thank you for suggesting this. The solution of using fixtures seems indeed cleaner and reusable.

[adimoldovan]

The fixture setup looks great @alvarothomas.
I checked the tests again and found some locators that should be updated to be unique to the review, otherwise the tests will fail if there are other reviews in the table besides the one in your test (which is very possible). See my suggested edits.
Also, the delete test needs another assertion, for the same reason. See my comments below.

I'm not sure about the scope of the task (if quick edit was the scope), but I'm wondering if editing the review via the review edit page should also be covered.
The same though with bulk delete.

[adimoldovan]

This looks good! Thank you @alvarothomas.