Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WooCommerce Blocks entry from the WooCommerce status page #44412

Merged

Conversation

nigeljamesstevenson
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/woocommerce-quality/issues/766

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1.Build this branch
2.Navigate to /wp-admin/admin.php?page=wc-status
3.Ensure there is no WooCommerce Blocks package entry:
image

It should appear as follows:
image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Remove WooCommerce Blocks entry from the WooCommerce status page

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 6, 2024
@nigeljamesstevenson nigeljamesstevenson requested a review from a team February 6, 2024 18:04
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hi , @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Test Results Summary

Commit SHA: e0cac71

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests295001903146m 17s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@lanej0
Copy link
Contributor

lanej0 commented Feb 7, 2024

Looks good to me @nigeljamesstevenson.

One of the checks was stuck, so I closed and re-opened the PR to kick off the checks again. Once they've completed, ready to merge.

@nigeljamesstevenson nigeljamesstevenson enabled auto-merge (squash) February 9, 2024 17:43
@nigeljamesstevenson nigeljamesstevenson merged commit c8f8299 into trunk Feb 9, 2024
47 checks passed
@nigeljamesstevenson nigeljamesstevenson deleted the update/remove-blocks-from-woocommerce-status-page branch February 9, 2024 17:44
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 9, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 9, 2024
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants