Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Gallery block: Focus should return to trigger element when closing pop-up #44414

Conversation

thealexandrelara
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #43761 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Navigate to Single Product template (Appearance > Editor > Templates > Single Product template).
  2. Click on "Edit" to open the Template editor.
  3. In the editor, you should see a block inserter icon or an option to "Add Block." Click on it.
  4. In the block inserter, search for "Product Gallery" or browse through the available blocks until you find it.
  5. Click on the "Product Gallery" block to add it to your content.
  6. Visit a product with multiple images.
  7. Using the keyboard, press 'Tab' multiple times until you select the "View All" button;
  8. Press 'Enter' or 'Space' to open the Product Gallery Pop-Up;
  9. Press 'Esc' to close the pop-up once it is open.
  10. Make sure the focus returns to the trigger element (the View All button);
  11. Keep pressing 'Tab' until you select the Large Image;
  12. Press 'Enter' to open the Product Gallery Pop-Up again.
  13. Press 'Esc' to close the pop-up once it is open.
  14. Make sure the focus returns to the trigger element (the Large Image);

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Focus return to the trigger element when closing the Product Gallery Pop-Up

Comment

@thealexandrelara thealexandrelara added type: bug The issue is a confirmed bug. team: Kirigami & Origami block: product gallery Issues related to the Product Gallery block. labels Feb 6, 2024
@thealexandrelara thealexandrelara self-assigned this Feb 6, 2024
@woocommercebot woocommercebot requested review from a team and Aljullu and removed request for a team February 6, 2024 19:24
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hi @Aljullu,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Test Results Summary

Commit SHA: dbf3b1b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests620024803105m 27s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with this! LGTM 🚢

@thealexandrelara thealexandrelara merged commit f7b92e8 into trunk Feb 7, 2024
46 checks passed
@thealexandrelara thealexandrelara deleted the fix/42335-focus-should-return-to-trigger-element-when-closing-pop-up branch February 7, 2024 20:18
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 7, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 7, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: product gallery Issues related to the Product Gallery block. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Gallery block: Focus should return to trigger element when closing pop-up
3 participants