New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sharding to Blocks e2e tests #44440
Conversation
Test Results SummaryCommit SHA: 07ebd1e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hi @gigitux, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Hey @gigitux -- I took a shot at sharding the blocks e2e Playwright tests in order to speed up their execution. Any concerns with this approach? |
No! It makes sense! Thanks for working on it! I would expect that everything should be green! I restarted this job because one test failed: https://github.com/woocommerce/woocommerce/actions/runs/7822790714/job/21416655727 It should be just flaky 🤞 |
…ry-sharding-blocks-tests
It is still failing. It's weird. I'm trying to rebase with trunk. |
It seems that there is an issue... I'm investigating it! |
I'm able to replicate locally as well. I will fix it next week! It is not a regression, but we have to update the E2E test code. Not sure why only now the CI fails :/ If you check this report, you can notice that the test is flaky, but still the test passes 🤔. |
Great! Thanks for taking a look at that. Feel free to push changes to this PR, and we can merge once everything is green. |
…ry-sharding-blocks-tests
…ry-sharding-blocks-tests
d4b6f35
to
aba2b41
Compare
Hi @lanej0, I address the failed E2E tests. Still, I'm not sure why it didn't fail before :/ @nielslange, I noticed that with this PR #43549, you updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, @lanej0. I'm pre-approving this PR, but let's wait for @nielslange feedback before merging this PR!
@gigitux I recall that I adjusted this test as it kept failing repeatedly. That said, I just started the local test environment, and for this test, there should be only one matching product. So, @lanej0's change looks good. Not sure what caused this test to fail earlier. |
@lanej0, feel free to merge the PR if you agree with my changes! |
Submission Review Guidelines:
Changes proposed in this Pull Request:
After sharding the Playwright test execution in core, and it working out well, this PR tries the same thing with the Blocks Playwright e2e tests -- hopefully speed up the execution a bit on these.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment