Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharding to Blocks e2e tests #44440

Merged
merged 13 commits into from Feb 15, 2024
Merged

Add sharding to Blocks e2e tests #44440

merged 13 commits into from Feb 15, 2024

Conversation

lanej0
Copy link
Contributor

@lanej0 lanej0 commented Feb 7, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

After sharding the Playwright test execution in core, and it working out well, this PR tries the same thing with the Blocks Playwright e2e tests -- hopefully speed up the execution a bit on these.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Test Results Summary

Commit SHA: 07ebd1e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests298002303217m 25s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@lanej0 lanej0 added the focus: e2e tests Issues related to e2e tests label Feb 8, 2024
@lanej0 lanej0 requested a review from gigitux February 8, 2024 22:09
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hi @gigitux,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@lanej0
Copy link
Contributor Author

lanej0 commented Feb 8, 2024

Hey @gigitux -- I took a shot at sharding the blocks e2e Playwright tests in order to speed up their execution. Any concerns with this approach?

@gigitux
Copy link
Contributor

gigitux commented Feb 9, 2024

Hey @gigitux -- I took a shot at sharding the blocks e2e Playwright tests in order to speed up their execution. Any concerns with this approach?

No! It makes sense! Thanks for working on it! I would expect that everything should be green! I restarted this job because one test failed: https://github.com/woocommerce/woocommerce/actions/runs/7822790714/job/21416655727

It should be just flaky 🤞

@gigitux
Copy link
Contributor

gigitux commented Feb 9, 2024

It is still failing. It's weird. I'm trying to rebase with trunk.

@github-actions github-actions bot removed the focus: e2e tests Issues related to e2e tests label Feb 9, 2024
@gigitux
Copy link
Contributor

gigitux commented Feb 9, 2024

It seems that there is an issue... I'm investigating it!

@gigitux
Copy link
Contributor

gigitux commented Feb 9, 2024

I'm able to replicate locally as well. I will fix it next week! It is not a regression, but we have to update the E2E test code. Not sure why only now the CI fails :/

If you check this report, you can notice that the test is flaky, but still the test passes 🤔.

@lanej0
Copy link
Contributor Author

lanej0 commented Feb 9, 2024

Great! Thanks for taking a look at that. Feel free to push changes to this PR, and we can merge once everything is green.

@gigitux gigitux force-pushed the dev/try-sharding-blocks-tests branch from d4b6f35 to aba2b41 Compare February 13, 2024 17:55
@gigitux
Copy link
Contributor

gigitux commented Feb 13, 2024

Hi @lanej0, I address the failed E2E tests. Still, I'm not sure why it didn't fail before :/

@nielslange, I noticed that with this PR #43549, you updated price-filter.block_theme.side_effects.spec.ts: https://github.com/woocommerce/woocommerce/pull/43549/files#diff-2e5f7ed9516b3c6a1aab17bf3f94322b62098f52d8b4d18a5753b5257458e465R86. On my local setup (and on the CI), the correct value is 1. Can you double-check?

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, @lanej0. I'm pre-approving this PR, but let's wait for @nielslange feedback before merging this PR!

@nielslange
Copy link
Member

Hi @lanej0, I address the failed E2E tests. Still, I'm not sure why it didn't fail before :/

@nielslange, I noticed that with this PR #43549, you updated price-filter.block_theme.side_effects.spec.ts: https://github.com/woocommerce/woocommerce/pull/43549/files#diff-2e5f7ed9516b3c6a1aab17bf3f94322b62098f52d8b4d18a5753b5257458e465R86. On my local setup (and on the CI), the correct value is 1. Can you double-check?

@gigitux I recall that I adjusted this test as it kept failing repeatedly. That said, I just started the local test environment, and for this test, there should be only one matching product. So, @lanej0's change looks good. Not sure what caused this test to fail earlier.

@rrennick rrennick added the tool: monorepo infrastructure Issues and PRs related to monorepo tooling. label Feb 14, 2024
@gigitux
Copy link
Contributor

gigitux commented Feb 15, 2024

@lanej0, feel free to merge the PR if you agree with my changes!

@lanej0 lanej0 merged commit 2812adc into trunk Feb 15, 2024
55 of 56 checks passed
@lanej0 lanej0 deleted the dev/try-sharding-blocks-tests branch February 15, 2024 17:27
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 15, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris tool: monorepo infrastructure Issues and PRs related to monorepo tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants