Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS] Ensure the font family for buttons match the one assigned for the content, not the title #44458

Merged
merged 2 commits into from Feb 12, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Feb 8, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes the button typhography for the "Montserrat + Arvo" and "Commissioner + Crimson Pro" font pairings.

Closes #44010

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Local or JN

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  4. Follow the process.
  5. Click on Change fonts.
  6. For each one of the font pairings available make sure they are correctly applied to buttons and titles. Pay special attention to the Montserrat + Arvo and Commissioner + Crimson Pro fonts.

WooExpress
Repeat the previous steps in a WooExpress store.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Fix button typhography for the "Montserrat + Arvo" and "Commissioner + Crimson Pro" font pairings.

Comment

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test Results Summary

Commit SHA: 3fddb9c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests303001103146m 31s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 8, 2024
@albarin albarin changed the title Fix select font for buttons [CYS] Ensure the font family for buttons match the one assigned for the content, not the title Feb 8, 2024
@albarin albarin marked this pull request as ready for review February 8, 2024 15:10
@woocommercebot woocommercebot requested a review from a team February 8, 2024 15:11
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hi @gigitux, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @albarin ! Confirmed the font pairings for the button are now correct.

@albarin albarin merged commit 7f8b1e2 into trunk Feb 12, 2024
41 checks passed
@albarin albarin deleted the 44010/fix-font-pairings branch February 12, 2024 08:25
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 12, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS] Ensure the font family for buttons match the one assigned for the content, not the title
3 participants