New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E] Update the blocks E2E setup guide #44468
Conversation
Hi @Aljullu, @imanish003, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: c649f59
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs, @WunderBart! I left one minor comment, but not a blocker. Besides that, everything LGTM.
By the way, heads-up that you will need to rebase on trunk
before merging to get Playwright tests to pass.
3e21a9d
to
60c76ed
Compare
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
c649f59
to
7df9c2f
Compare
7df9c2f
to
e2abc2c
Compare
Changes proposed in this Pull Request:
While setting up the repo for the first time, I encountered some issues with installing Playwright browsers and setting up the e2e env. I've updated the readme with the steps that helped me fix those issues.
Ref: p1707400637260049-slack-C04JMARP9LK
Changelog entry
Significance
Type
Message
Comment