Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Update the blocks E2E setup guide #44468

Merged
merged 4 commits into from Feb 14, 2024

Conversation

WunderBart
Copy link
Contributor

Changes proposed in this Pull Request:

While setting up the repo for the first time, I encountered some issues with installing Playwright browsers and setting up the e2e env. I've updated the readme with the steps that helped me fix those issues.

Ref: p1707400637260049-slack-C04JMARP9LK

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@woocommercebot woocommercebot requested review from a team and imanish003 and removed request for a team February 8, 2024 16:47
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hi @Aljullu, @imanish003,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@WunderBart WunderBart self-assigned this Feb 8, 2024
@WunderBart WunderBart added the focus: documentation Issues and PRs related to improving documentation label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test Results Summary

Commit SHA: c649f59

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 40s
E2E Tests297001703146m 41s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs, @WunderBart! I left one minor comment, but not a blocker. Besides that, everything LGTM.

By the way, heads-up that you will need to rebase on trunk before merging to get Playwright tests to pass.

plugins/woocommerce-blocks/tests/e2e/README.md Outdated Show resolved Hide resolved
@WunderBart WunderBart force-pushed the chore/update-blocks-e2e-readme branch from 3e21a9d to 60c76ed Compare February 9, 2024 10:27
@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. and removed focus: documentation Issues and PRs related to improving documentation labels Feb 13, 2024
@WunderBart WunderBart enabled auto-merge (squash) February 13, 2024 16:41
@WunderBart WunderBart merged commit 2432b3b into trunk Feb 14, 2024
20 checks passed
@WunderBart WunderBart deleted the chore/update-blocks-e2e-readme branch February 14, 2024 14:00
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 14, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 14, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants