New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Gallery block > Pop-Up: Fix overlay sizing issue #44479
Conversation
Hi @kmanijak, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 713606e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I didn't spot any issues! 🚀
Changes proposed in this Pull Request:
This PR fixes an issue when you visit a product with a single image and open the Product Gallery Pop-Up. Depending on the size of the image, if it does not fill the entire screen, it can cause the background to be an incorrect color and the close button to appear in the middle of the screen.
Closes #43826 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Fix overlay sizing issue with the Product Gallery Pop-Up.
Comment