New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC][Product Block Editor]: introduce custom Block Binding API #44524
Draft
retrofox
wants to merge
26
commits into
trunk
Choose a base branch
from
introduce/custom-block-binding-api
base: trunk
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+692
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
label
Feb 9, 2024
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
retrofox
force-pushed
the
introduce/custom-block-binding-api
branch
from
February 9, 2024 20:24
dd1c823
to
05ffa69
Compare
Test Results SummaryCommit SHA: eb0d061
Please address the following issues prior to merging this pull request: |
retrofox
force-pushed
the
introduce/custom-block-binding-api
branch
from
February 19, 2024 16:14
05ffa69
to
10e74ed
Compare
2 tasks
retrofox
changed the title
[Product Block Editor]: introduce custom Block Binding API
[PoC][Product Block Editor]: introduce custom Block Binding API
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
focus: new product ux
revamped product management experience
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR introduces the Block Binding API in the product editor app.
Considering that the API is in full development in core, we have introduced an alternative implementation fully aligned with what the core API dictates.
Ideally, when the API is available in core we could switch without any problem.
Additionally, a source handler will be added that connects the block's attributes with the product's entities.
Finally, as an example of use, the product name field is connected to the entity.
Closes # .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Basic
General
tab,Basic details
sectionInspect the Name field block
metadata
attribute therePro: dispatching an action to update the product property
<post-id>
with your testing productThe best product ever'
)Pro: dispatching an action to update the block property
Screen.Recording.2024-02-09.at.17.57.26.mov
Changelog entry
Significance
Type
Message
Comment