New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core - CYS: fix inter font not applied #44544
Conversation
Hi @albarin, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed Inter
font is working! TY!
Test Results SummaryCommit SHA: 47d1073
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Changes proposed in this Pull Request:
These changes are necessary because the default font family of TT4 is called "Inter". Instead, the font family installed during the setup is called "Inter, sans serif": the issue is that both of them are the same slug. This caused the font "Inter, sans serif" didn't enable due to this logic: 447a6c1#diff-9d845082930383f4e8624300508b6237fcae0d9ca593d29111492cd0bca4c6a3R105-R122.
Overall, we should not rely on the fonts pre-installed with the theme because they can change with an update. For this reason, only the fonts installed during the setup must be enabled.
Closes #44543.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.wp-admin/admin.php?page=wc-admin&path=/customize-store
.Inter
font is applied correctly.Changelog entry
Significance
Type
Message
Comment
Core - CYS: fix Inter font not applied.