Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core - CYS: fix inter font not applied #44544

Merged
merged 3 commits into from Feb 12, 2024
Merged

Core - CYS: fix inter font not applied #44544

merged 3 commits into from Feb 12, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Feb 12, 2024

Changes proposed in this Pull Request:

These changes are necessary because the default font family of TT4 is called "Inter". Instead, the font family installed during the setup is called "Inter, sans serif": the issue is that both of them are the same slug. This caused the font "Inter, sans serif" didn't enable due to this logic: 447a6c1#diff-9d845082930383f4e8624300508b6237fcae0d9ca593d29111492cd0bca4c6a3R105-R122.

Overall, we should not rely on the fonts pre-installed with the theme because they can change with an update. For this reason, only the fonts installed during the setup must be enabled.

Closes #44543.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new WooCommerce installation with this version.
  2. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  3. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  4. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  5. Follow the process.
  6. Due to this bug, it is necessary to refresh the page to ensure that the fonts are loaded.
  7. Click on "Change Fonts".
  8. Ensure that the Inter font is applied correctly.
  9. Ensure that the rest of the fonts are applied correctly.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Core - CYS: fix Inter font not applied.

@gigitux gigitux added type: bug The issue is a confirmed bug. team: Kirigami & Origami focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Feb 12, 2024
@gigitux gigitux self-assigned this Feb 12, 2024
@woocommercebot woocommercebot requested a review from a team February 12, 2024 13:52
Copy link
Contributor

github-actions bot commented Feb 12, 2024

Hi @albarin, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 12, 2024
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed Inter font is working! TY!

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Test Results Summary

Commit SHA: 47d1073

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests290002703175m 25s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@gigitux gigitux enabled auto-merge (squash) February 12, 2024 14:05
@gigitux gigitux merged commit 738a57f into trunk Feb 12, 2024
25 checks passed
@gigitux gigitux deleted the fix/inter-not-applied branch February 12, 2024 14:09
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 12, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS - Core] Inter font isn't applied
3 participants