New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core - CYS: fix fonts not loaded on the font picker iframes #44586
Core - CYS: fix fonts not loaded on the font picker iframes #44586
Conversation
Hi @albarin, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: b439daa
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Confirmed the fonts are being correctly loaded on the sidebar.
@@ -181,6 +204,13 @@ export const FontPairingVariationPreview = () => { | |||
onLoad={ handleOnLoad } | |||
/> | |||
) } | |||
{ isNoAIFlow( context.flowType ) && ( | |||
<FontFamiliesLoader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #44427.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Local Installation
/wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag./wp-admin/admin.php?page=wc-settings&tab=advanced§ion=woocommerce_com
and enable the tracking.wp-admin/admin.php?page=wc-admin&path=/customize-store
.Change your font
.Woo Express installation
/wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.Change your font
.Changelog entry
Significance
Type
Message
Comment