Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core - CYS: fix fonts not loaded on the font picker iframes #44586

Merged

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Feb 13, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #44427.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Local Installation

  1. Create a new WooCommerce installation with this version.
  2. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  3. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  4. Install this build of Gutenberg that contains the new Font Library API: gutenberg.zip
  5. Go on /wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com and enable the tracking.
  6. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  7. Follow the process.
  8. Click on Change your font.
  9. For each preview, ensure that the right fonts are rendered.

image

Woo Express installation

  1. Create a new WooCommerce installation with this version.
  2. Ensure Jetpack is installed and your site is connected with JP.
  3. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  4. Ensure the Woo AI plugin is installed and activated (available on this monorepo).
  5. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  6. Head over to WooCommerce -> Home and click on "Start Customizing".
  7. Ensure that all the flow works correctly.
  8. Follow the process.
  9. Click on Change your font.
  10. For each preview, ensure that the right fonts are rendered.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@gigitux gigitux added type: bug The issue is a confirmed bug. focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Feb 13, 2024
@gigitux gigitux self-assigned this Feb 13, 2024
@gigitux gigitux linked an issue Feb 13, 2024 that may be closed by this pull request
@woocommercebot woocommercebot requested a review from a team February 13, 2024 15:57
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 13, 2024
Copy link
Contributor

github-actions bot commented Feb 13, 2024

Hi @albarin, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results Summary

Commit SHA: b439daa

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests1220019903215m 11s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Confirmed the fonts are being correctly loaded on the sidebar.

@@ -181,6 +204,13 @@ export const FontPairingVariationPreview = () => {
onLoad={ handleOnLoad }
/>
) }
{ isNoAIFlow( context.flowType ) && (
<FontFamiliesLoader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gigitux gigitux merged commit cb1ae99 into trunk Feb 14, 2024
31 checks passed
@gigitux gigitux deleted the 44427-cys-on-core-fix-fonts-are-not-loaded-on-the-font-picker branch February 14, 2024 09:30
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 14, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 14, 2024
@rodelgc rodelgc added status: analysis complete Indicates if a PR has been analysed by Solaris needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on Core] Fix fonts are not loaded on the font picker
3 participants