New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test publishing #44592
Remove test publishing #44592
Conversation
Hi @adimoldovan, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 6aa7efe
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, but I wonder if it would make sense to also rename the workflow to non-hpos-build-and-e2e-tests-daily.yml
? The same with the job names in the workflow, a rename from hpos-...
to non-hpos...
?
Good call. I made the update to the filename. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Here's a couple if you don't want to wait:
Changelog entry
Significance
Type
Message
Comment