Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test publishing #44592

Merged
merged 5 commits into from Feb 15, 2024
Merged

Remove test publishing #44592

merged 5 commits into from Feb 15, 2024

Conversation

lanej0
Copy link
Contributor

@lanej0 lanej0 commented Feb 13, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

  1. Swap the HPOS and non-HPOS testing workflows. HPOS is the default, so it should be for our tests too.
  2. Disable the publishing of daily test results to the dashboard for non HPOS runs (they aren't being displayed there)

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Actions > Smoke test daily
  2. Run the workflow using this branch and make sure there's no issues
  3. Go to Actions > Run daily tests in an environment with HPOS enabled
  4. Run this workflow using this branch and make sure there's no issues

Here's a couple if you don't want to wait:

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@lanej0 lanej0 added the focus: e2e tests Issues related to e2e tests label Feb 13, 2024
@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. tools: monorepo infrastructure and removed focus: e2e tests Issues related to e2e tests labels Feb 13, 2024
@woocommercebot woocommercebot requested a review from a team February 13, 2024 19:38
Copy link
Contributor

github-actions bot commented Feb 13, 2024

Hi @adimoldovan,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results Summary

Commit SHA: 6aa7efe

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests252006903216m 28s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@adimoldovan adimoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, but I wonder if it would make sense to also rename the workflow to non-hpos-build-and-e2e-tests-daily.yml? The same with the job names in the workflow, a rename from hpos-... to non-hpos...?

.github/workflows/smoke-test-daily.yml Show resolved Hide resolved
@rrennick rrennick added tool: monorepo infrastructure Issues and PRs related to monorepo tooling. and removed tools: monorepo infrastructure labels Feb 14, 2024
@lanej0
Copy link
Contributor Author

lanej0 commented Feb 14, 2024

The change looks good to me, but I wonder if it would make sense to also rename the workflow to non-hpos-build-and-e2e-tests-daily.yml? The same with the job names in the workflow, a rename from hpos-... to non-hpos...?

Good call. I made the update to the filename.

@adimoldovan adimoldovan self-requested a review February 14, 2024 20:49
@lanej0 lanej0 merged commit c3b355a into trunk Feb 15, 2024
31 of 32 checks passed
@lanej0 lanej0 deleted the fix/daily-hpos-no-report branch February 15, 2024 00:41
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 15, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris tool: monorepo infrastructure Issues and PRs related to monorepo tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants