Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up block templates after running e2e tests #44600

Merged
merged 3 commits into from Feb 15, 2024

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Feb 14, 2024

Changes proposed in this Pull Request:

Closes #44445.

As discussed in #44363 (comment), if one test failed in our e2e tests related to block customization, it might leave customized templates lingering around, polluting new tests. This PR cleans up block templates in an afterAll().

How to test the changes in this Pull Request:

Note: no need to test this for the release.

  1. Verify e2e tests pass.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 14, 2024
@Aljullu Aljullu self-assigned this Feb 14, 2024
@Aljullu Aljullu added focus: template Issue related to WooCommerce templates. team: Kirigami & Origami labels Feb 14, 2024
@Aljullu Aljullu marked this pull request as ready for review February 14, 2024 08:51
@woocommercebot woocommercebot requested review from a team and ObliviousHarmony and removed request for a team February 14, 2024 08:53
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Hi @ObliviousHarmony, @thealexandrelara,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Test Results Summary

Commit SHA: c10e4f5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests308001303216m 59s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@thealexandrelara thealexandrelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement for our e2e tests, thank you for working on this! 🙌

@Aljullu Aljullu merged commit dd56a3b into trunk Feb 15, 2024
40 checks passed
@Aljullu Aljullu deleted the fix/44445-clean-up-block-templates branch February 15, 2024 07:17
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 15, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: template Issue related to WooCommerce templates. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up block templates after e2e tests are run
3 participants