Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e/customer emails #44622

Merged
merged 4 commits into from Feb 15, 2024
Merged

E2e/customer emails #44622

merged 4 commits into from Feb 15, 2024

Conversation

lanej0
Copy link
Contributor

@lanej0 lanej0 commented Feb 14, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Adds e2e tests for checking emails sent when:

  • New customer created
  • Admin-initiated password reset
  • Customer-initiated password reset

Closes https://github.com/woocommerce/woocommerce-quality/issues/720

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Pull branch
  2. pnpm env:restart
  3. pnpm test:e2e-pw shopper/account-email-receiving.spec.js

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@lanej0 lanej0 added the focus: e2e tests Issues related to e2e tests label Feb 14, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 14, 2024
@lanej0 lanej0 requested a review from a team February 14, 2024 19:01
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Test Results Summary

Commit SHA: fbbf527

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests31800603246m 58s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@adimoldovan adimoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested good for me 👍🏼

Eslint is complaining about some stuff, mostly formatting. I'm approving, but if you could fix those before merging it would be great.

pnpm eslint tests/e2e-pw/tests/shopper/account-email-receiving.spec.js

[...]

✖ 35 problems (30 errors, 5 warnings)
  30 errors and 0 warnings potentially fixable with the `--fix` option.

@lanej0 lanej0 merged commit fce80c4 into trunk Feb 15, 2024
30 checks passed
@lanej0 lanej0 deleted the e2e/customer-emails branch February 15, 2024 21:07
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 15, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants