Fix removal of express payment method from state

[tarunvijwani]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

With this PR, we are fixing the behavior of the REMOVE_AVAILABLE_EXPRESS_PAYMENT_METHOD reducer to correctly remove the specified express payment method.

Closes #44694.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Enable Stripe and Paypal express payment methods.
2. Add a product to the Cart and visit the Checkout block page.
3. Notice there are 3 express checkout buttons.
4. Open console log and run wp.data.dispatch( 'wc/store/payment').__internalRemoveAvailableExpressPaymentMethod('payment_request') code to remove stripe's express payment method.
5. Confirm stripe express payment method is removed correctly.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Fixed a bug where express payment methods could not be removed from the wc/store/payment data store.

Comment

[github-actions]

Test Results Summary

Commit SHA: db387c8

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	296	0	0	29	0	325	6m 34s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @opr,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[opr]

Thanks @tarunvijwani this is testing OK for me, the code changes look 99% good too, just a couple of changes needed (I don't think the reducer test is a huge deal, but it would be nice to make sure we're being consistent with the test data vs. real life data)

[tarunvijwani]

Thanks @tarunvijwani this is testing OK for me, the code changes look 99% good too, just a couple of changes needed (I don't think the reducer test is a huge deal, but it would be nice to make sure we're being consistent with the test data vs. real life data)

Thank you so much for the suggestion. I have updated the tests and changelog. 👍

[opr]

Thanks Tarun, looks good now! 👏🏼

[tarunvijwani]

Thank you for reviewing the PR, @opr! 🎉