New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e tests] Enhance product reviews tests #44644
Conversation
…est-product-reviews-list
…est-product-reviews-list
Test Results SummaryCommit SHA: 36c17b8
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hi , @woocommerce/solaris, @woocommerce/vortex Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, looks good. Thanks!
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes https://github.com/woocommerce/woocommerce-quality/issues/609 .
A test for viewing reviews already existed, so I only updated it to check for more than one review for more than one product.
Added a new test for reviews filtering by product.
I also had to update the other tests as they were failing for more than one review. The fix was to narrow down the locators using the review id.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Run locally with
pnpm env:restart && pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/product-reviews.spec.js
Changelog entry
Significance
Type
Message
Comment