Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Enhance product reviews tests #44644

Merged
merged 9 commits into from Feb 15, 2024
Merged

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Feb 15, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/woocommerce-quality/issues/609 .

A test for viewing reviews already existed, so I only updated it to check for more than one review for more than one product.
Added a new test for reviews filtering by product.
I also had to update the other tests as they were failing for more than one review. The fix was to narrow down the locators using the review id.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Run locally with pnpm env:restart && pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/product-reviews.spec.js

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@adimoldovan adimoldovan self-assigned this Feb 15, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Feb 15, 2024
Copy link
Contributor

github-actions bot commented Feb 15, 2024

Test Results Summary

Commit SHA: 36c17b8

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests306001603226m 44s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@adimoldovan adimoldovan changed the title [e2e tests] Update product review tests to work with more reviews [e2e tests] Enhance product reviews tests Feb 15, 2024
@adimoldovan adimoldovan marked this pull request as ready for review February 15, 2024 20:54
@woocommercebot woocommercebot requested a review from a team February 15, 2024 20:54
@adimoldovan adimoldovan requested a review from a team February 15, 2024 20:54
Copy link
Contributor

github-actions bot commented Feb 15, 2024

Hi , @woocommerce/solaris, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, looks good. Thanks!

@lanej0 lanej0 merged commit ddf908d into trunk Feb 15, 2024
36 checks passed
@lanej0 lanej0 deleted the e2e/test-product-reviews-list branch February 15, 2024 21:30
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 15, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants