New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e tests] Add tests for product inventory in product block editor #44699
Conversation
Test Results SummaryCommit SHA: 8c70540
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
…roduct-inventory-block-editor
…roduct-inventory-block-editor
Hi , @woocommerce/solaris, @woocommerce/vortex Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
…roduct-inventory-block-editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes https://github.com/woocommerce/woocommerce-quality/issues/623 .
Adds new tests covering product inventory using product block editor.
I also removed the
describe
blocks in some specs, they are not needed byPlaywright test
and it looks much cleaner to me. (Happy to add them back if we want them there for a good reason).How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Run locally with
pnpm env:restart && pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/products/block-editor/product-inventory-block-editor.spec.js
.Changelog entry
Significance
Type
Message
Comment