Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Add tests for product inventory in product block editor #44699

Merged
merged 15 commits into from Feb 20, 2024

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Feb 16, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/woocommerce-quality/issues/623 .

Adds new tests covering product inventory using product block editor.
I also removed the describe blocks in some specs, they are not needed by Playwright test and it looks much cleaner to me. (Happy to add them back if we want them there for a good reason).

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Run locally with pnpm env:restart && pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/products/block-editor/product-inventory-block-editor.spec.js.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@adimoldovan adimoldovan self-assigned this Feb 16, 2024
Copy link
Contributor

github-actions bot commented Feb 16, 2024

Test Results Summary

Commit SHA: 8c70540

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests265007503408m 20s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Feb 16, 2024
@adimoldovan adimoldovan marked this pull request as ready for review February 19, 2024 14:36
@adimoldovan adimoldovan requested review from a team February 19, 2024 14:36
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Hi , @woocommerce/solaris, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanej0 lanej0 merged commit f4f4d79 into trunk Feb 20, 2024
30 checks passed
@lanej0 lanej0 deleted the e2e/product-inventory-block-editor branch February 20, 2024 22:25
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 20, 2024
@nigeljamesstevenson nigeljamesstevenson removed the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 21, 2024
@nigeljamesstevenson nigeljamesstevenson added the status: analysis complete Indicates if a PR has been analysed by Solaris label Feb 21, 2024
@octaedro octaedro mentioned this pull request Feb 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants