Blocks E2E: Setup block theme without opening browser #44702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For initial call it improves the speed from ~8.5s to ~5.3s (~38%). - For subsequent calls it goes down from ~8.5s to ~230ms (~97%) by recognizing the theme being already set. These absolute measurements are valid ForMyMachine™ :)
|
Hi @lanej0, @gigitux, @kmanijak, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
github-actions
bot
added
the
plugin: woocommerce
Test Results SummaryCommit SHA: 472caa7
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
WunderBart
changed the title
WunderBart
changed the title
WunderBart
changed the title
kmanijak
approved these changes
Feb 20, 2024
github-actions
bot
added
the
needs: analysis
nigeljamesstevenson
added
status: analysis complete
WunderBart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In
block-theme.setup.ts:wp rewrite flushas it's already called within the precedingwp rewrite structurecall,How to test the changes in this Pull Request:
Change the theme slug in
block-theme.setup.tsto a non-existing theme.Run some test that uses the
block_theme.setup.ts, for example:Ensure the assertion failed and printed
Could not install and/or activate ${ BLOCK_THEME_SLUG }.