Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default values for admin address filters #44704

Merged
merged 2 commits into from Feb 16, 2024
Merged

Add default values for admin address filters #44704

merged 2 commits into from Feb 16, 2024

Conversation

senadir
Copy link
Member

@senadir senadir commented Feb 16, 2024 •
edited by wavvves

Submission Review Guidelines:

Changes proposed in this Pull Request:

Recently in the work we did for additional fields, we expanded some WooCommerce Order filters like woocommerce_admin_shipping_fields and woocommerce_admin_billing_fields filters and added 2 new arguments, we also consume them in our work.

This created an issue for other plugins who recall those hooks with the old number of parameters.

To fix this, I added default values to where we consume them.

Issue reported here https://wordpress.org/support/topic/fatal-error-after-woocommerce-update-9

How to test the changes in this Pull Request:

  1. Install this plugin AliExpress Dropshipping with AliNext Lite
  2. Visit an order page.
  3. You shouldn't see a fatal.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Add default values for 'woocommerce_admin_billing_fields' and 'woocommerce_admin_shipping_fields' filters

Comment

@senadir senadir self-assigned this Feb 16, 2024
@senadir senadir added type: bug The issue is a confirmed bug. focus: checkout Issues related to checkout page. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues labels Feb 16, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 16, 2024
@woocommercebot woocommercebot requested review from a team and wavvves and removed request for a team February 16, 2024 14:33
@github-actions GitHub Actions
Copy link
Contributor

Hi @wavvves,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited

Test Results Summary

Commit SHA: 3efde4d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests282004303256m 43s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

wavvves
wavvves approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@wavvves wavvves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing checks out, thanks for the blazing fast PR @senadir 💪🏼

@wavvves wavvves merged commit e8a403b into trunk Feb 16, 2024
54 of 56 checks passed
@wavvves wavvves deleted the fix/add-default-value-for-additional-fields-filter branch February 16, 2024 15:10
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 16, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 16, 2024
@wavvves wavvves changed the title add default values for admin address filters Add default values for admin address filters Feb 16, 2024
@nigeljamesstevenson nigeljamesstevenson modified the milestones: 8.7.0, 8.6.0 Feb 16, 2024
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
@senadir
add default values for admin address filters (#44704)
eb0a776 
* add default values for "woocommerce_admin_shipping_fields" and "woocommerce_admin_billing_fields" filters

* use null instead
This was referenced Feb 16, 2024
Merged
Merged
nigeljamesstevenson pushed a commit that referenced this pull request Feb 16, 2024
@github-actions @senadir
Cherry pick 44704 into release/8.6 (#44729)
7d74685 
* add default values for admin address filters (#44704)

* add default values for "woocommerce_admin_shipping_fields" and "woocommerce_admin_billing_fields" filters

* use null instead

* Prep for cherry pick 44704

---------

Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com>
Co-authored-by: WooCommerce Bot <no-reply@woo.com>
@Stojdza Stojdza added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris labels Feb 20, 2024
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
@senadir
add default values for admin address filters (#44704)
dd65fe9 
* add default values for "woocommerce_admin_shipping_fields" and "woocommerce_admin_billing_fields" filters

* use null instead
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Merged
alopezari pushed a commit that referenced this pull request Feb 21, 2024
@github-actions @senadir
Cherry pick 44704 into release/8.7.0.10 (#44849)
e6238ed 
* add default values for admin address filters (#44704)

* add default values for "woocommerce_admin_shipping_fields" and "woocommerce_admin_billing_fields" filters

* use null instead

* Prep for cherry pick 44704

---------

Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com>
Co-authored-by: WooCommerce Bot <no-reply@woo.com>
@nigeljamesstevenson nigeljamesstevenson removed the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 21, 2024
@alopezari alopezari added the fix release: 8.6.1 Temporary label for fix release metrics retrieval label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wavvves wavvves wavvves approved these changes

Assignees

@senadir senadir

Labels
fix release: 8.6.1 Temporary label for fix release metrics retrieval focus: checkout Issues related to checkout page. needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@senadir @wavvves @Stojdza @alopezari @nigeljamesstevenson