Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/44643 variation empty state experiment #44731

Merged
merged 2 commits into from Feb 20, 2024

Conversation

louwie17
Copy link
Contributor

@louwie17 louwie17 commented Feb 16, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Updates the experiment name for the latest WC Release.

Partially addresses #44643 .

How to test the changes in this Pull Request:

  1. Open your console and go to Application > Local Storage and make sure the item with key: explat-experiment--woocommerce_product_creation_experience_empty_state_updates_202403_v1 is removed or does not exist.
  2. Go to the ExPlat experiment woocommerce_product_creation_experience_empty_state_updates_202403_v1 and choose the variation you want to test. ( Note: When testing each version make sure you have the product editor feature flag disabled. For example when it is enabled the task list will ignore the experiment and always redirect to the new editor, meaning that testing the control version doesn't seem to work ).
  3. When hovering over any Bookmarklet link of control or treatment variation, a popover should appear with instructions to try one of the variations ( redo step 1 when switch treatment versions ).
  4. Be sure to save the suggested link to your browser bookmarks.
  5. Go to WooCommerce > Home and go through the OBW ( Onboarding workflow ) or skip it.
  6. Go to /wp-admin/admin.php?page=wc-admin and click on the second item to add a new product.
  7. Click on the bookmark saved in step 3.
  8. After clicking the saved bookmark, a modal with this title should be shown ExPlat: Successful Assignment
    Close the modal.
  9. Click on any of the product types ( test a couple ).
    If you chose the "control" variation, you should see the old/legacy product form.
    If you selected the "treatment" variation, you should see the blocks product editor.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 16, 2024
@louwie17 louwie17 requested a review from a team February 16, 2024 21:12
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Test Results Summary

Commit SHA: 2a6fdce

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests323001303367m 10s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@louwie17 louwie17 enabled auto-merge (squash) February 20, 2024 15:30
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louwie17 louwie17 merged commit 79375d5 into trunk Feb 20, 2024
36 checks passed
@louwie17 louwie17 deleted the add/44643_variation_empty_state_experiment branch February 20, 2024 15:41
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 20, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants