Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Experimental] Remove fe filter variations in favor of separately registered wrapper blocks #44747

Closed
wants to merge 1 commit into from

Conversation

samueljseay
Copy link
Contributor

@samueljseay samueljseay commented Feb 19, 2024

Changes proposed in this Pull Request:

The wrapper blocks for the front-end filters are always named "Product Filter" which makes for confusing block hierarchy. A user should be able to see what filter its for without expanding the block tree. This fixes that by registering separate blocks for each wrapper block instead of using variations.

Resolves #44752

How to test the changes in this Pull Request:

TBD
3.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@woocommercebot woocommercebot requested review from a team and albarin and removed request for a team February 19, 2024 05:10
Copy link
Contributor

Hi @albarin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@samueljseay samueljseay removed the request for review from albarin February 19, 2024 05:12
Copy link
Contributor

Test Results Summary

Commit SHA: 5d19e2d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests319001703368m 49s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better block labeling
1 participant