Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix untranslated "Are you already selling somewhere else?" text in the product task list #44763

Merged
merged 2 commits into from Feb 20, 2024

Conversation

chihsuan
Copy link
Member

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #44075.

Fix untranslated "Are you already selling somewhere else?" text in the product task list

How to test the changes in this Pull Request:

This is a minor change. Reviewing the changes should be sufficient

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@chihsuan chihsuan self-assigned this Feb 19, 2024
@chihsuan chihsuan requested review from a team, psealock and rjchow February 19, 2024 09:41
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 19, 2024
Copy link
Contributor

Hi @psealock, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Test Results Summary

Commit SHA: 566b76a

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests318001803368m 38s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chihsuan chihsuan merged commit 2f68187 into trunk Feb 20, 2024
38 checks passed
@chihsuan chihsuan deleted the fix/untranslated-product-task-text branch February 20, 2024 02:25
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 20, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Make text on /admin.php?page=wc-admin&task=products translatable
3 participants