[CYS] Update path to intro when exiting the assembler #44771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
force-pushed
the
44766-fix-cys-wrong-path
branch
from
927ee68
to
51ce48a
Compare
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
albarin
requested review from
gigitux and
nefeline
and removed request for
dinhtungdu
|
Hi @gigitux, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 3574a24
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Thanks for your work here, @albarin ! I'm seeing an intermediary (seems to be the editor) screen whenever clicking on Exit and lose changes: Screen.Recording.2024-02-20.at.10.15.08.movIs this expected? |
Hmm, it's not, I'm not sure why is this happening. I'll need to investigate. |
github-actions
bot
added
the
needs: analysis
nigeljamesstevenson
added
needs: external testing
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Update path to intro when exiting the assembler * Add changefile(s) from automation for the following project(s): woocommerce * Fix styling * Fix linting error --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #44766
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Testerplugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag.WooCommerce > Home, click onStart customizing, and finish the flow.Let's get creativetitleExit and lose changes.wp-admin/admin.php?page=wc-admin&customizing=true&path=%2Fcustomize-store%2Fintro.Changelog entry
Significance
Type
Message
[CYS] Fix the intro path when exiting the assembler.
Comment