Blocks E2E: Stabilize Product Collection "on sale" tests #44796
Merged
+33
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was flaky because we were comparing the current count of elements to an unknown count of elements calculated by `locator.count()`. That method is inherently unstable, because it only counts the currently available elements, where the rest can still be loading. Furthermore, effective tests should verify the system against known, expected outcomes to ensure it behaves as intended under certain conditions. Without comparing to a fixed value, you cannot guarantee that the system is meeting its specified requirements.
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
Hi @tjcafferkey, @imanish003, @kmanijak, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 3722918
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
github-actions
bot
added
the
plugin: woocommerce
kmanijak
approved these changes
Feb 21, 2024
github-actions
bot
added
the
needs: analysis
alvarothomas
added
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Feb 22, 2024
WunderBart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Fix flaky
Products can be filtered based on "on sale" statustest.This test was flaky because we compared the current count of elements to an unknown count of elements calculated by
locator.count(). That method is inherently unstable because it includes only the currently available elements, whereas the rest might still be loading.Clean up the suite & apply some good practices.
How to test the changes in this Pull Request:
There no need to test manually. This suite should pass in CI. For safe measure, it should be restarted a couple of times to ensure the aforementioned test was indeed stabilized.