Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer large Twitter icons to X #44807

Merged
merged 3 commits into from Feb 22, 2024
Merged

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Feb 20, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR updates the Large Footer and Large Footer Dark Twitter icons to X and adds the appropriate URLs.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new page or post
  2. Insert the Large Footer Dark and the Large Footer patterns.
  3. Check you don't see any Twitter icons but X ones.
  4. Check the URLs of the icons point to the right URL.
  5. Save, open the page and check you see the same on the frontend.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Update "Large Footer" and "Large Footer Dark" Twitter icons to X and update the social URLs.

Comment

@albarin albarin marked this pull request as ready for review February 20, 2024 15:16
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 20, 2024
@woocommercebot woocommercebot requested review from a team and ObliviousHarmony and removed request for a team February 20, 2024 15:16
Copy link
Contributor

Hi @ObliviousHarmony,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Test Results Summary

Commit SHA: 7bb924a

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests329001503448m 47s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@albarin albarin force-pushed the update-twitter-icon-large-footer branch from 787ccc2 to ab8fc64 Compare February 21, 2024 08:31
@albarin albarin merged commit b142db0 into trunk Feb 22, 2024
60 checks passed
@albarin albarin deleted the update-twitter-icon-large-footer branch February 22, 2024 08:34
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 22, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 22, 2024
@veljkho veljkho added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants