Fix block templates not being rendered in extension taxonomies

[Aljullu]

Changes proposed in this Pull Request:

Alternative approach from #44646.

Closes #44453. (Update: it turns out #44537 already fixed this issue)

In some circumstances, woocommerce_has_block_template wasn't set to true correctly, that meant that we were rendering a broken PHP template instead of the correct block template.

The issue was only reproducible in block themes with certain custom WooCommerce templates (ie: Tsubaki, which has the archive-product.html template), and were only reproducible in these cases:

• When rendering a product archive page belonging to a taxonomy with no template in the theme. That's excluding the category, tag and attribute taxonomies. So it was only reproducible in taxonomies added by extensions.
• When rendering the Shop page with certain filters (what's described in Shop Page Filter Query Causes Inconsistent Block UI Rendering Without Product Attribute Lookup Table #44453). (Update: This was already fixed in trunk thanks to Shop Page Filter Query Causes Inconsistent Block UI Rendering Without Product Attribute Lookup Table #44453)

This PR removes a check we had in the code that would only set woocommerce_has_block_template if the template was not in the theme.

How to test the changes in this Pull Request:

Verify correct template is rendered with certain settings (#44453)

(Update: this issue was actually fixed in #44537, but I'm adding the testing steps here just to verify there are no regressions)

1. With a theme with custom WooCommerce templates (ie: Tsubaki).
2. Go to WooCommerce > Settings > Products > Advanced and disable Use the product attributes lookup table for catalog filtering.
3. With a block theme with custom WooCommerce templates (ie: Tsubaki) go to /shop/?product_cat=Clothing&filter_size=large. Note: the values of product_cat and filter_xyz might vary depending on the categories and attributes of your store. In case of doubt, you can import the products from sample-data.
4. Verify the page is rendered correctly. Ie: verify the header is displayed, verify the page has the Shop title, verify the styles are loaded, etc.

Before	After

Verify taxonomies added by extensions are rendered correctly (testing for devs)

1. With a theme with custom WooCommerce templates (ie: Tsubaki).
2. Install WooCommerce Brands.
3. In the admin, create a brand, edit a product and assign that product to the brand you just created.
4. Visit the brand page in the frontend (the page should render correctly).
5. Edit class-wc-brands-block-templates.php and comment out this line: add_filter( 'woocommerce_has_block_template', array( $this, 'has_block_template' ), 10, 2 );.
6. Visit the brand page again. Verify the page still renders correctly.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: d275bac

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 39s
E2E Tests	76	0	0	275	0	351	6m 31s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @WunderBart, @imanish003,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[imanish003]

Hey @Aljullu,

I've tested the changes and everything is functioning as anticipated. I've left some minor comments and will await your response before giving my approval to this PR 🚀.

Thank you for your excellent work around templates so far 🙌🏻

[WunderBart]

I can repro #44453, but this PR doesn't seem to fix it. Here's what I see for the following themes on both trunk and this branch:

2024	Tsubaki	Storefront

Looks like Storefront is affected as well, and only 2024 seems to render the results correctly.

EDIT

I misunderstood the issue, but it seems to have been actually fixed on trunk as well as the page does not render differently on this branch.

[Aljullu]

I misunderstood the issue, but it seems to have been actually fixed on trunk as well as the page does not render differently on this branch.

You're right, @WunderBart! It looks like the refactor PR (#44537) already fixed that issue. 😄 I updated the description of this PR and the refactor PR to account for that.

[Aljullu]

Thanks for the reviews, folks! I think all comments have been answered and I updated the PR description and testing steps to account for the fact that #44453 was already fixed in trunk (sorry for the confusion!). This PR is ready for another look.

PS: even though #44453 has been fixed in trunk, I still think there is value in merging this PR because (1) it simplifies the code and (2) solves the issue described under the Verify taxonomies added by extensions are rendered correctly testing section.

[imanish003]

I verified the changes again & everything is working as expected