add: update onboarding task list copies and illustrations

[rjchow]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Updated copies and illustrations according to latest designs: Y5pUYSJPsGEud1vknUZhi8-fi-3352%3A22233

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Ensure that customise-store feature flag is enabled
2. Go through the onboarding task list and check that the copies and illustration match designs

Variations:

• Shipping task only shows up for countries that don't have shipping smart defaults, e.g Afghanistan
• WCPay only shows up in place of the regular payments task if WCPay is installed and activated

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 1006a29

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	76	0	0	275	0	351	6m 33s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[ilyasfoo]

Shipping task only shows up for countries that don't have shipping smart defaults, e.g Afghanistan

I wasn't able to get the Shipping task to show when I chose Afghanistan via setup wizard. I used Hong Kong instead.

While reviewing, I noticed that we no longer have a way to display the "Import your products" variation of product task. I think it's because the condition here checks for selling_venues, which is deprecated since the new core profiler.

I think it makes sense to fix this bug along with updating the copies, since one of the use cases in Figma explicitly mentions it. I believe changing it to check business_choice == im_already_selling to show import variant is sufficient. What do you think?

Also, I don't see any changes regarding the WooPayments incentive screen (The Limited time offer copy). I'm not sure if it should be implemented in this PR since it might be obtained externally, but I think we'll need to communicate if we don't - perhaps WooPayments team can work on it?

[rjchow]

Shipping task only shows up for countries that don't have shipping smart defaults, e.g Afghanistan

I wasn't able to get the Shipping task to show when I chose Afghanistan via setup wizard. I used Hong Kong instead.

Should have verified this, I was set to a country that worked and didn't check what it was 🙈

While reviewing, I noticed that we no longer have a way to display the "Import your products" variation of product task. I think it's because the condition here checks for selling_venues, which is deprecated since the new core profiler.

I think it makes sense to fix this bug along with updating the copies, since one of the use cases in Figma explicitly mentions it. I believe changing it to check business_choice == im_already_selling to show import variant is sufficient. What do you think?

Do need to fix this! I skipped it in the hurry last night and never got back to it. Thanks for catching that!

Also, I don't see any changes regarding the WooPayments incentive screen (The Limited time offer copy). I'm not sure if it should be implemented in this PR since it might be obtained externally, but I think we'll need to communicate if we don't - perhaps WooPayments team can work on it?

I couldn't find the text string in our repo I think, and I saw that it was being fetched from window so I skipped it. Good call to ping someone about it 😅

[rjchow]

• Added change to remove the estimated times
• Did not address change for the import product header as some PHP change will be required for the tasklist item text as well, which I'm not currently prepared to do and after discussion it's been okay-d to punt this to a later date
• For the woo payments incentive copy, I traced the source down to https://github.com/Automattic/woocommerce-payments-server/pull/3499 and discussed it with the team over there - there's no release cycle constraint and all that's needed is to make a text change on L715

[ilyasfoo]

Thanks, @rjchow! Tests well!

Did not address change for the import product header as some PHP change will be required for the tasklist item text as well, which I'm not currently prepared to do and after discussion it's been okay-d to punt this to a later date

Sounds good, did you create a follow-up issue? I can help to create the issue if you want. Or do you plan to work on it after this is merged?

[rjchow]

@ilyasfoo I can make the issue! I already actually did some work which I reverted cec152c because I realised the task list title text was mismatched

Edit: issue - #45500 , https://github.com/woocommerce/team-ghidorah/issues/292

[chihsuan]

Thanks, lgtm and tested well. 👍

[adrianduffell]

It tested great, @rjchow ! Thanks for adding the follow-up issues. Triple approval! 🚀