Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS] Mark the products task as completed only if products were user created #44890

Merged
merged 3 commits into from Feb 26, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Feb 22, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #44887

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Click on Tools and run the Reset Customize Your Store and the Delete all products commands.
  4. Go to WooCommerce > Home, click on Start customizing, and finish the flow.
  5. Go back to WooCommerce > Home again and make sure the 2. Add products task is not marked as completed (is not crossed out).
  6. Go to Products on the WordPress sidebar and check you have 6 dummy products generated by the CYS flow.
  7. Create a new product.
  8. Go back to WooCommerce > Home again and make sure the second task You added products is marked as completed (is crossed out).
  9. Delete the product you created, go back to the Home, and make sure the task is again not completed.
  10. Go to Products, edit, and save the generated products.
  11. Go back to the Home, and make sure the task is again completed.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Mark the product's task as completed only if products were created or modified by users.

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 22, 2024
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Test Results Summary

Commit SHA: 49859d7

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests251009303446m 47s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin albarin force-pushed the cys-fix-complete-products-task branch from b83fe6b to e21d9f0 Compare February 22, 2024 14:12
@albarin albarin marked this pull request as ready for review February 22, 2024 14:12
@woocommercebot woocommercebot requested review from a team and dinhtungdu and removed request for a team February 22, 2024 14:13
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Hi @dinhtungdu, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work here @albarin !

✅ Confirmed that the products task is marked as completed only when the store owner actually creates products (dummy products do not count as "real" products 👍 ).

@albarin albarin merged commit c177998 into trunk Feb 26, 2024
41 checks passed
@albarin albarin deleted the cys-fix-complete-products-task branch February 26, 2024 09:14
@github-actions github-actions bot added this to the 8.8.0 milestone Feb 26, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 26, 2024
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 26, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
…created (#44890)

* Mark the products task as completed only if products were user created

* Consider the edited products as user products

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS] Only mark the Products task as completed when the products are user generated
3 participants