New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS] Mark the products task as completed only if products were user created #44890
Conversation
Test Results SummaryCommit SHA: 49859d7
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
b83fe6b
to
e21d9f0
Compare
Hi @dinhtungdu, @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work here @albarin !
✅ Confirmed that the products task is marked as completed only when the store owner actually creates products (dummy products do not count as "real" products 👍 ).
…created (#44890) * Mark the products task as completed only if products were user created * Consider the edited products as user products * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com>
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #44887
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Tester
plugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.Tools
and run theReset Customize Your Store
and theDelete all products
commands.WooCommerce > Home
, click onStart customizing
, and finish the flow.WooCommerce > Home
again and make sure the2. Add products
task is not marked as completed (is not crossed out).Products
on the WordPress sidebar and check you have 6 dummy products generated by the CYS flow.WooCommerce > Home
again and make sure the second taskYou added products
is marked as completed (is crossed out).Products
, edit, and save the generated products.Changelog entry
Significance
Type
Message
CYS - Mark the product's task as completed only if products were created or modified by users.
Comment