Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear out unneeded github files from block folder #44895

Merged
merged 2 commits into from Feb 29, 2024

Conversation

rrennick
Copy link
Contributor

Changes proposed in this Pull Request:

Dependabot was accidentally re-enabled in the repo during the blocks merge. This PR deletes the blocks dependabot configuration file & other files in the plugins/woocommerce-blocks/.github folder that we are unlikely to reference again. A copy of these files still exist in the woocommerce-blocks repo on the unlikely event that we need to reference them.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Review list of files being deleted

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@rrennick rrennick added tool: monorepo infrastructure Issues and PRs related to monorepo tooling. focus: housekeeping Issues related to code/tooling cleanup activities. labels Feb 22, 2024
@rrennick rrennick requested a review from a team February 22, 2024 16:50
@github-actions github-actions bot removed the tool: monorepo infrastructure Issues and PRs related to monorepo tooling. label Feb 22, 2024
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@rrennick rrennick added the tool: monorepo infrastructure Issues and PRs related to monorepo tooling. label Feb 22, 2024
@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. and removed tool: monorepo infrastructure Issues and PRs related to monorepo tooling. labels Feb 22, 2024
@rrennick rrennick added tool: monorepo infrastructure Issues and PRs related to monorepo tooling. and removed plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Feb 22, 2024
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Test Results Summary

Commit SHA: 5407afa

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests329001503448m 5s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the cleanup.

@rrennick rrennick merged commit ccef3d2 into trunk Feb 29, 2024
60 checks passed
@rrennick rrennick deleted the dev/cleanup-blocks-github-folder branch February 29, 2024 17:30
@github-actions github-actions bot added this to the 8.8.0 milestone Feb 29, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 29, 2024
@alvarothomas alvarothomas added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 1, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
* clear out unneeded github files from block folder

* copy changelog to woocommerce folder

---------

Co-authored-by: Ron Rennick <ronald.rennick@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: housekeeping Issues related to code/tooling cleanup activities. status: analysis complete Indicates if a PR has been analysed by Solaris tool: monorepo infrastructure Issues and PRs related to monorepo tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants