Add simple products to the Analytics orders query for the attributes filter

[louwie17]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Modifies the attributes filter to include simple products that use global attributes.

Closes #32237

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Create two global attributes, like: size with terms: small, medium, large and colour with terms: red, yellow, blue.
2. Create two products one simple product and one variable

• The simple can contain one attribute of each ( small and red? ), can name it a "small red t-shirt"
• The variable can include all options of both attributes, can name it "Variable t-shirts"

3. Buy the simple product in an order by it-self
4. Buy the variable product with the small attribute selected and any colour.
5. Mark the order as completed
6. Go to WooCommerce > Status > Scheduled actions and make sure none are pending.
7. Go to Reports > Orders
8. Change the date to from beginning of the year to today
9. Filter by advanced search
10. Choose attribute from the list
11. Set to "is", and choose Size and pick attribute small
12. Click 'filter'
13. There should be two orders present, one with the simple product and one with the variable
14. If you selected a different colour for the variable order then the simple product then add another attribute filter and choose Color
15. It should show the correct data.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 6147225

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	327	0	0	24	0	351	7m 39s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[louwie17]

$term_id wasn't previously being used, but now it is, this makes sure it is set in both instances.

[louwie17]

Added an order sub query, to see if a simple product has a matching attribute id.
Note: this query works only for simple products with global attributes, given the attributes filter only shows global attributes to filter by.

[octaedro]

I'm not a fan of this line. Maybe extracting the subquery to a new variable would improve its legibility.

Maybe something like this would work:

$prepared_term_id = intval( $term_id );
$subquery = "SELECT product_id FROM {$wpdb->prefix}wc_product_attributes_lookup WHERE is_variation_attribute = 0 AND term_id = {$prepared_term_id}";
$where_condition = "
	( ( {$join_alias}.meta_key = %s AND {$join_alias}.meta_value {$comparator} %s ) OR
		({$wpdb->prefix}wc_order_product_lookup.variation_id = 0 AND
		{$wpdb->prefix}wc_order_product_lookup.product_id {$in_comparator} ({$subquery}) ) )";
$sql_clauses['where'][] = $wpdb->prepare( $where_condition, $meta_key, $meta_value );

[louwie17]

Addressed as part of: 96f2b45

[louwie17]

This is 11 now, because previously even when using is_not it would filter out any orders with simple products. Now the query actually works correctly for is_not.

[github-actions]

Hi @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[octaedro]

Good job @louwie17! The code looks good and is testing well on my end. I left a small suggestion, although the PR is ok as it is now, so I'll approve it.

[louwie17]

@octaedro could you have another look and also test it once more ( I don't have time ) and if good merge it for me?
I just addressed your feedback.

As I just submitted new changes

[octaedro]

LGTM! 🚀