New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide unnecessary order attribution details #44907
Hide unnecessary order attribution details #44907
Conversation
Test Results SummaryCommit SHA: ab2a71d
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hi , @woocommerce/ventures Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change. The UI is much clearer this way.
Thanks for the eyes @budzanowski |
* Hide more details for simple sources
Changes proposed in this Pull Request:
This is a small change to the Order Attribution metabox to hide the "More details" dropdown for a specific set of sources. Unknown sources already had the "more details" toggle hidden, but this PR hides it for direct, web admin, and mobile app orders too.
Screenshots
🟡 Before changes:
Direct, Web admin and Mobile app "More details" are always the same, and not informative.
🟢 With changes:
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
sbjs_
cookies after each orderhref
in developer tools to point to the store. Add items to the cart and complete the checkout.https://woocommerce.store/shop/?utm_source=newsletter&utm_medium=email&utm_campaign=sale&utm_content=utmcontent&utm_term=utm_term
. Add items to the cart and complete the checkout._wc_order_attribution_source_type
tomobile_app
. This can be done using the filteradd_filter( 'is_protected_meta', '__return_false' );
then editing the meta value on the Order edit page._wc_order_attribution_*
meta values.Changelog entry
Significance
Type
Message
Comment