Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow to use latest checkout actions #45199

Merged
merged 8 commits into from Feb 29, 2024
Merged

Update workflow to use latest checkout actions #45199

merged 8 commits into from Feb 29, 2024

Conversation

lanej0
Copy link
Contributor

@lanej0 lanej0 commented Feb 28, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Updates the PR testing workflow to eliminate the GitHub warnings for deprecated Node.js use:

Screenshot 2024-02-28 at 3 22 20 PM

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Just make sure that the API and E2E tests pass in CI on this PR. The warnings in the screenshot above should not appear in the summary of the workflow run.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: monorepo infrastructure Issues and PRs related to monorepo tooling. labels Feb 28, 2024
@woocommercebot woocommercebot requested a review from a team February 28, 2024 23:23
@github-actions GitHub Actions
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited

Test Results Summary

Commit SHA: bbcc650

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests318003303517m 2s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added the focus: e2e tests Issues related to e2e tests label Feb 29, 2024
@lanej0 lanej0 marked this pull request as draft February 29, 2024 00:28
@lanej0 lanej0 marked this pull request as ready for review February 29, 2024 19:32
@woocommercebot woocommercebot requested a review from a team February 29, 2024 19:32
lanej0
lanej0 commented Feb 29, 2024
View reviewed changes
plugins/woocommerce/tests/e2e-pw/playwright.config.js
@@ -23,6 +23,7 @@ const config = {
retries: CI ? 2 : 0,
repeatEach: REPEAT_EACH ? Number( REPEAT_EACH ) : 1,
workers: 1,
reportSlowTests: { max: 5, threshold: 30 * 1000 }, // 30 seconds threshold
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked some somewhat arbitrary numbers here, we can adjust. What this says is that a test will be reported as slow if it takes longer than 30 seconds. The max number is that it's reporting the 5 slowest tests per shard... having a list of more than 25 tests probably isn't super productive.

@lanej0
Copy link
Contributor Author

lanej0 commented Feb 29, 2024

This PR is mostly geared towards cleaning up the annotations on test runs: https://github.com/woocommerce/woocommerce/actions/runs/8101450263?pr=45199

It eliminates some deprecation warnings and tries to limit the number of slow tests reported to a manageable number.

rrennick
rrennick approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @lanej0.

@rrennick rrennick merged commit bf43cf7 into trunk Feb 29, 2024
34 checks passed
@rrennick rrennick deleted the dev/update-workflow-node-20 branch February 29, 2024 22:58
@github-actions github-actions bot added this to the 8.8.0 milestone Feb 29, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 29, 2024
@alvarothomas alvarothomas removed the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 1, 2024
@alvarothomas alvarothomas added the status: analysis complete Indicates if a PR has been analysed by Solaris label Mar 1, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
@lanej0 @Konamiman
Update workflow to use latest checkout actions (#45199)
e400bae 
* Update workflow to use latest checkout actions

* Update non-HPOS workflow as well

* Update additional actions

* Set a slow test threshold at 30 seconds (15 is default)

* Final action updates

* Slow tests has to be an object

* Pin external actions to commit

* Slow test threshold and max

---------

Co-authored-by: Jon Lane <jon.lane@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrennick rrennick rrennick approved these changes

Assignees
No one assigned
Labels
focus: e2e tests Issues related to e2e tests focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Milestone
8.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lanej0 @rrennick @alvarothomas