Fix intro CYS logo and site title #45216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
force-pushed
the
fix-cys-intro-css
branch
from
eb4b475
to
13aebcd
Compare
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 07de2c1
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Thanks for working on this! It doesn't look like a regression introduced in this PR, but I noticed that during the transition between the assembler hub and the intro page, the logo has a weird animation: Screen.Capture.Feb.29.at.16-11.mp4Given that this PR is smaller, it could make sense to include the fix in this PR. WDYT? |
|
@gigitux Thanks for the feedback, I've applied the changes you mentioned on Slack. |
github-actions
bot
added
the
needs: analysis
thealexandrelara
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Fix intro CYS logo and site title * Add changefile(s) from automation for the following project(s): woocommerce * Improve format * Fix logo motion --------- Co-authored-by: github-actions <github-actions@github.com>
alvarothomas
added
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Fix intro CYS logo and site title * Add changefile(s) from automation for the following project(s): woocommerce * Improve format * Fix logo motion --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes a CSS issue with the CYS intro page logo and site title.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Testerplugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag.Toolsand run theReset Customize Your Storeand theDelete all productscommands.WooCommerce > Home, click onStart customizing.Afterscreenshot below:Changelog entry
Significance
Type
Message
CYS - Fix the intro page logo and site title positioning.
Comment