Explicitly clear out customers before testing #45229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: e2e tests
|
Hi , @woocommerce/vortex Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: c31b3e5
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
rrennick
reviewed
Feb 29, 2024
| await api.get( 'customers' ).then( ( response ) => { | ||
| oldCustomers = response.data; | ||
| } ); | ||
| await api.post( `customers/batch`, { |
There was a problem hiding this comment.
Will it create an api error if oldCustomers is empty?
There was a problem hiding this comment.
Nope, I tested it locally on my machine where there are no customers and no error is thrown. So it works either way.
adimoldovan
approved these changes
Mar 1, 2024
github-actions
bot
added
the
needs: analysis
alvarothomas
added
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
Co-authored-by: Jon Lane <jon.lane@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Fixes the e2e failure that we're seeing on the "On PR merge" workflow. This explicitly clears out any existing customers before running the customer list tests.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment