[CYS] Fix the selected pattern in footer, header and homepage #45240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
albarin
changed the title
albarin
force-pushed
the
45215-fix-selected-footer
branch
from
807bd38
to
5bb00a8
Compare
woocommercebot
requested review from
a team and
ObliviousHarmony
and removed request for
a team
albarin
requested review from
gigitux and
nefeline
and removed request for
ObliviousHarmony
|
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: dd607cf
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
gigitux
requested changes
Mar 4, 2024
albarin
changed the title
albarin
force-pushed
the
45215-fix-selected-footer
branch
from
f177231
to
0a6dcf9
Compare
That's right, I just pushed a fix for the homepage as well. Could you check again @gigitux ? |
gigitux
approved these changes
Mar 5, 2024
github-actions
bot
added
the
needs: analysis
rodelgc
added
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Check also the number of inner blocks before checking the attributes * Add classes to assembler footer patterns * Add classes to assembler header patterns * Add changefile(s) from automation for the following project(s): woocommerce * Mark the current homepage template as selected * Remove unused import --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
The problem was that the comparison to select a pattern was to compare their block attributes. We had 2 patterns with the same attributes so when selecting the last one it always matched the first.
In this PR I'm adding a specific class to each of the patterns to make their attributes different. Also, I've added an extra comparison to check if the number of inner blocks is the same.
Closes #45215
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Testerplugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag.Toolsand run theReset Customize Your Storeand theDelete all productscommands.WooCommerce > Home, and click onStart customizing.Choose your footer, select a pattern, and go back by clicking on the arrow.Choose your header.Changelog entry
Significance
Type
Message
CYS - Fix the selected pattern in footer in the assembler.
Comment