Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Post-purchase note field to the Inventory tab #45244

Merged
merged 2 commits into from Mar 5, 2024
Merged

Conversation

mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Mar 1, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #41740

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure feature New product editor is enabled under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
  2. Go to Products > Add new from the left side menu.
  3. Add a Name to the product
  4. Go to the Inventory tab.
  5. A new text area Post-purchase note should be shown
image
  1. Add any note there and make sure the changes are persisted between refreshes.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@mdperez86 mdperez86 added focus: new product ux revamped product management experience team: Mothra labels Mar 1, 2024
@mdperez86 mdperez86 requested a review from a team March 1, 2024 14:55
@mdperez86 mdperez86 self-assigned this Mar 1, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Test Results Summary

Commit SHA: ff9ce0b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests34400703517m 37s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mdperez86! This is testing well here and the code LGTM :shipit:

I just have a sidenote. Should we add the post-purchase note to variations? If the answer is yes maybe we can tackle that in this PR.

@octaedro
Copy link
Contributor

octaedro commented Mar 5, 2024

I just have a sidenote. Should we add the post-purchase note to variations? If the answer is yes maybe we can tackle that in this PR.

@mdperez86 In answer to my own question, variations retain the note added in this field (which, in the old editor, is located under the Advanced options). That means that if we want to add a specific note for a specific variation, we would need to change core. So, let's move forward with this PR and continue analyzing whether adding this feature is something we will want to pursue in the future or not.

@mdperez86 mdperez86 merged commit 33d38be into trunk Mar 5, 2024
45 checks passed
@mdperez86 mdperez86 deleted the add/41740 branch March 5, 2024 14:12
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 5, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 5, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 6, 2024
@nigeljamesstevenson nigeljamesstevenson added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Mar 6, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
* Add Post-purchase note field to the Inventory tab

* Add changelog file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. release: highlight Issues that have a high user impact and need to be discussed/paid attention to. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Post-purchase note field to the Inventory tab
4 participants