New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental] Filter blocks: Add block preview #45258
[Experimental] Filter blocks: Add block preview #45258
Conversation
Hi @roykho, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: b1197f7
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previews shows up nicely good work however I wanted to point out for the Attributes Filter, since it needs to first pick an attribute before showing the real preview, it is not ideal. I understand this has existed prior but perhaps we should figure out a way to make it work.
One thought is to use placeholder screenshots and in the edit.js, if isPreview
load the screenshot.
But it is not a blocker so approving.
d0bf331
to
9f9d2ab
Compare
Nice catch! I'm going to open a new issue to work specifically for the Attributes Filter! Thank you for pointing this out and sharing a solution. |
* Add block preview to filter blocks * Add changefile(s) from automation for the following project(s): woocommerce-blocks --------- Co-authored-by: github-actions <github-actions@github.com>
Changes proposed in this Pull Request:
This PR adds the block preview to each Product Filter block.
Closes #44748.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Add block preview to filter blocks
Comment