[CYS on Core] Ensure the user is directed to the in app marketplace whenever clicking on 'Browse all themes' #45288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng on 'Browse all themes' on core.
nefeline
added
the
focus: customize-your-store
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
nefeline
added
type: enhancement
|
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: b6df101
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
…ed-to-the-in-app-marketplace-whenever-clicking-on-browse-all-themes
nefeline
deleted the
45284-cys-on-core-ensure-the-user-is-directed-to-the-in-app-marketplace-whenever-clicking-on-browse-all-themes
branch
github-actions
bot
added
the
needs: analysis
alvarothomas
added
needs: external testing
nigeljamesstevenson
added
the
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
…henever clicking on 'Browse all themes' (#45288) * Ensure the user is directed to the in app marketplace whenever clicking on 'Browse all themes' on core. * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Whenever the store owner clicks on "Browse all themes", they should be directed to:
/wp-admin/admin.php?page=wc-admin&tab=themes&path=%2Fextensionson core while at the same time keeping the functionality on WooExpress unchanged.isWooExpress()for this purpose, the plan is to switch this logic later on to an approach that is environment agnostic, relying on hooks instead for achieving all environment-specific changes.Closes #45284
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Initial Setup
customize-storeTest on Core
/wp-admin/admin.php?page=wc-admin&tab=themes&path=%2Fextensionsas demonstrated in the video below:Screen.Recording.2024-03-04.at.16.34.26.mov
Test on WooExpress
3 Click on the "Start customizing" or the "Customize Your Store" button
https://wordpress.com/themes/{your_site_name}as demonstrated in the video below:Screen.Recording.2024-03-04.at.16.55.02.mov
Changelog entry
Significance
Type
Message
Ensure the user is directed to the in-app marketplace whenever clicking on 'Browse all themes' within the Customize Your Store flow.
Comment