Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CYS on Core] Display the theme switch modal only if the current active theme is not TT4 #45296

Merged
merged 3 commits into from Mar 5, 2024
Merged

[CYS on Core] Display the theme switch modal only if the current active theme is not TT4 #45296

merged 3 commits into from Mar 5, 2024

Conversation

nefeline
Copy link
Member

@nefeline nefeline commented Mar 4, 2024 •
edited

Submission Review Guidelines:

Changes proposed in this Pull Request:

Ensure the theme switch warning modal in the transitional page of the CYS is displayed exclusively for WordPress installs with a theme different than TT4.

Add a new recording event called 'customize_your_store_agree_to_theme_switch_click' whenever the user clicks on the "Design a new theme" button.

⚠️ Further changes are planned to be implemented as part of a separate PR to identify if the TT4 theme has been modified by the user.

Closes #45281

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Initial Setup

  1. Enable the WooCommerce Beta Tester plugin if you don't have it yet
  2. On your Dashboard, head over to Tools > WCA Test Helper > Features and enable the customize-store

Test Scenario One: The user has a theme different than TT4

  1. Make sure your site has an active theme that is different than TT4
  2. Access your Dashboard and head over to WooCommerce > Home
  3. Click on the "Customize Your Store" button
  4. Click on the "Start designing" button
  5. Make sure the following modal is displayed:
Screenshot 2024-03-05 at 00 02 20
  1. Click on "Design a new theme"
  2. Go through the CYS flow and as soon as the loading screen finishes loading, click on the "Done" button in the Assembler.
  3. Make sure your current active theme has been changed to Twenty-twenty four.

Test Scenario Two: The user has the TT4 theme enabled

  1. Make sure your site has the TT4 theme enabled
  2. Access your Dashboard and head over to WooCommerce > Home
  3. Click on the "Customize Your Store" button
  4. Click on the "Start designing" button
  5. Ensure that you see the loading screen immediately after clicking the button (no modal should be displayed):
Screenshot 2024-03-05 at 00 09 39

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Display the theme switch modal in the Customize Your Store flow only if the currently active theme is not TT4

Comment

@nefeline nefeline linked an issue Mar 4, 2024 that may be closed by this pull request
[CYS on Core] Display the theme switch modal only if the current active theme is not TT4 #45281
Closed
@woocommercebot woocommercebot requested review from a team and samueljseay and removed request for a team March 4, 2024 23:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited

Hi @albarin, @gigitux,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@nefeline nefeline requested review from albarin and gigitux and removed request for samueljseay March 4, 2024 23:13
@nefeline nefeline self-assigned this Mar 4, 2024
@nefeline nefeline added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: enhancement The issue is a request for an enhancement. team: Kirigami & Origami focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited

Test Results Summary

Commit SHA: ae6538b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 39s
E2E Tests337001403517m 30s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

gigitux
gigitux approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! LGTM!

⚠️ Further changes are planned to be implemented as part of a separate PR to identify if the TT4 theme has been modified by the user.

It makes sense! 🚀

albarin
albarin approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@nefeline
Merge branch 'trunk' into 45281-cys-on-core-identify-if-the-current-a…
ae6538b 
…ctive-tt4-theme-has-been-already-modified-by-the-user
@nefeline nefeline enabled auto-merge (squash) March 5, 2024 09:59
@nefeline nefeline merged commit 298cddf into trunk Mar 5, 2024
26 checks passed
@nefeline nefeline deleted the 45281-cys-on-core-identify-if-the-current-active-tt4-theme-has-been-already-modified-by-the-user branch March 5, 2024 10:11
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 5, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 5, 2024
@alvarothomas alvarothomas added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 5, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
@nefeline @Konamiman
[CYS on Core] Display the theme switch modal only if the current acti…
bd2ec3a 
…ve theme is not TT4 (#45296)

* Ensure the active theme switch modal is displayed only if the theme is different than TT4

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albarin albarin albarin approved these changes

@gigitux gigitux gigitux approved these changes

Assignees

@nefeline nefeline

Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
8.8.0
Development

Successfully merging this pull request may close these issues.

[CYS on Core] Display the theme switch modal only if the current active theme is not TT4
4 participants
@nefeline @albarin @gigitux @alvarothomas