Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Specs: Update endpoints to 2.0 #45298

Merged
merged 5 commits into from Mar 12, 2024
Merged

Conversation

psealock
Copy link
Contributor

@psealock psealock commented Mar 5, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

All remote specs endpoints have recently been bumped. There is no change in current functionality, but future changes will be reflected in the new endpoint versions.

  • PaymentGatewaySuggestions
  • RemoteInboxNotifications
  • RemoteFreeExtensions
  • WCPayPromotion
  • ShippingPartnerSuggestions

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Visit all the URLs changed to 2.0 in this PR and confirm they work

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Bump all remote spec endpoints to version 2.0.

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 5, 2024
…ges/php/remote-specs-validation, woocommerce
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Test Results Summary

Commit SHA: 5956a68

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests338001303517m 45s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@psealock psealock closed this Mar 10, 2024
@psealock psealock reopened this Mar 10, 2024
@psealock psealock requested review from a team, adrianduffell and rjchow March 10, 2024 23:48
Copy link
Contributor

Hi @adrianduffell, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM and tested well. 💯

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @psealock! It seems this is missing update for https://github.com/Automattic/woocommerce.com/pull/19718

@psealock
Copy link
Contributor Author

Good catch @ilyasfoo, updated in 5956a68

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, LGTM! 🚢

@psealock psealock merged commit 172bbac into trunk Mar 12, 2024
33 checks passed
@psealock psealock deleted the update/remote-endpoints-2.0 branch March 12, 2024 02:54
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 12, 2024
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants