New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Specs: Update endpoints to 2.0 #45298
Conversation
…ges/php/remote-specs-validation, woocommerce
Test Results SummaryCommit SHA: 5956a68
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
…woocommerce into update/remote-endpoints-2.0
Hi @adrianduffell, @rjchow, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM and tested well. 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @psealock! It seems this is missing update for https://github.com/Automattic/woocommerce.com/pull/19718
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, LGTM! 🚢
Submission Review Guidelines:
Changes proposed in this Pull Request:
All remote specs endpoints have recently been bumped. There is no change in current functionality, but future changes will be reflected in the new endpoint versions.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
2.0
in this PR and confirm they workChangelog entry
Significance
Type
Message
Bump all remote spec endpoints to version
2.0
.Comment