Prevent backup post from being deleted when HPOS is authoritative

[jorgeatorres]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

When HPOS is authoritative, calling wp_delete_post() on a backup post also removes the HPOS order. By default, this shouldn't happen, but it can happen when, for example, sync is temporarily disabled and the backup post is kept in the trash, which will get autoremoved once WP empties the trash (and thus also deleting the HPOS order).

There are other implications as a few caches and stats are updated when an order is removed, and a post with shop_order as type would trigger this even when HPOS is set as datastore and the "true" order hasn't been deleted.

While those are some edge cases, they could happen. This PR short-circuits wp_delete_post() so that when HPOS is authoritative, any attempts to delete the backup post are not successful. This only applies to non placeholder posts, as placeholder posts won't trigger the cascade of operations that might be problematic here.

It's worth mentioning that our sync code doesn't consider missing backup posts as truly missing and will let you switch datastores freely, which can result in an incorrect "view" of the orders on your site. That's addressed in #45332, but this PR will at least make sure that can't happen again.

Closes #42746.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Make sure HPOS is configured as datastore and that compatibility mode is enabled in WC > Settings > Features > Advanced.
2. Ensure your test site has a few orders. Create as necessary.
3. Choose an order ID and run wp eval "wp_delete_post( <ORDER_ID> );".
4. Confirm that the order still exists on the HPOS side and, in particular, in the order stats table (which proves that the post deletion hooks did not run):

    wp db query "SELECT * FROM $(wp db prefix)wc_order_stats WHERE order_id = <ORDER_ID>"
   

5. Change datastore to posts in WC > Settings > Features > Advanced.
6. Run wp eval "wp_delete_post( <ORDER_ID> );" again and confirm that the order has been removed, and also from the HPOS tables (and stats table):

    wp db query "SELECT * FROM $(wp db prefix)wc_orders WHERE id = <ORDER_ID>"
    wp db query "SELECT * FROM $(wp db prefix)wc_order_stats WHERE order_id = <ORDER_ID>"
   

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 2a39b3b

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	339	0	0	12	0	351	7m 34s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[coreymckrill]

👍 Looks good, tests well. I also tried deleting some non-order posts to make sure this filter doesn't cause disruption for other post types.