Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks E2E: Do not report slow tests #45375

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

WunderBart
Copy link
Contributor

@WunderBart WunderBart commented Mar 7, 2024

Changes proposed in this Pull Request:

Currently, we're seeing a lot of Slow Test warnings in both CI and local test reports, e.g.:

Screenshot 2024-03-07 at 12 20 16 Screenshot 2024-03-07 at 11 18 17

Let's disable Playwright's slow test reporting, as it can be confusing because we're not running our tests in parallel.

This setting is also consistent with the core config.

How to test the changes in this Pull Request:

Ensure there are no more slow test reports.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Disable the reportSlowTests option for blocks' E2E tests.

Comment

@WunderBart WunderBart requested a review from gigitux March 7, 2024 10:25
@WunderBart WunderBart self-assigned this Mar 7, 2024
@woocommercebot woocommercebot requested a review from a team March 7, 2024 10:25
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Hi @gigitux, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense! LGTM! Thanks!

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test Results Summary

Commit SHA: a451ad3

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests341001003517m 29s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@WunderBart WunderBart force-pushed the tweak/disable-report-slow-tests branch from 6d12082 to a280cf9 Compare March 7, 2024 11:11
@WunderBart WunderBart force-pushed the tweak/disable-report-slow-tests branch from 8686663 to a451ad3 Compare March 7, 2024 11:24
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 7, 2024
@WunderBart WunderBart merged commit 8ff89fa into trunk Mar 7, 2024
55 of 56 checks passed
@WunderBart WunderBart deleted the tweak/disable-report-slow-tests branch March 7, 2024 11:57
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 7, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 7, 2024
@alvarothomas alvarothomas added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants