Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks E2E: Be more descriptive with the workflow titles #45381

Merged
merged 4 commits into from Mar 7, 2024

Conversation

WunderBart
Copy link
Contributor

@WunderBart WunderBart commented Mar 7, 2024

Changes proposed in this Pull Request:

Tweak the Blocks E2E job titles to make them more descriptive so they're easier to follow and debug:

  • Remove the Playwright E2E tests - prefix as it's already a Run Blocks Playwright Tests workflow.
  • Rename Normal to Default (Block) Theme to reflect the env setup better.
  • Rename Classic to Classic Theme for the same reason.
  • Add shard numbers for correct sorting and easier navigation.
Before After
Screenshot 2024-03-07 at 14 14 13 Screenshot 2024-03-07 at 14 14 29

How to test the changes in this Pull Request:

Ensure the new titles are displayed correctly.

@WunderBart WunderBart self-assigned this Mar 7, 2024
@github-actions github-actions bot added the tool: monorepo infrastructure Issues and PRs related to monorepo tooling. label Mar 7, 2024
@woocommercebot woocommercebot requested a review from a team March 7, 2024 11:39
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Hi @lanej0, @gigitux, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test Results Summary

Commit SHA: 9d163dc

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests295005603517m 8s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 7, 2024
@WunderBart WunderBart enabled auto-merge (squash) March 7, 2024 13:21
@WunderBart WunderBart merged commit 211b6ef into trunk Mar 7, 2024
49 checks passed
@WunderBart WunderBart deleted the tweak/blocks-e2e-workflow branch March 7, 2024 13:32
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 7, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 7, 2024
@alvarothomas alvarothomas added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris tool: monorepo infrastructure Issues and PRs related to monorepo tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants