New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS on core] Set the default width after logo update #45384
Conversation
Hi @gigitux, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
3f4f398
to
6031b01
Compare
Test Results SummaryCommit SHA: 6031b01
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! 🚢
* Set default width after logo update * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com>
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #45379
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Tester
plugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.Tools
and run theReset Customize Your Store
and theDelete all products
commands.WooCommerce > Home
, click onStart customizing
and finish the flow.Add your logo
.60px
in theImage width
selector and on the preview.Changelog entry
Significance
Type
Message
CYS - Set a default width for the site logo after uploading it.
Comment