Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS on core] Set the default width after logo update #45384

Merged
merged 2 commits into from Mar 7, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Mar 7, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45379

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Click on Tools and run the Reset Customize Your Store and the Delete all products commands.
  4. Go to WooCommerce > Home, click on Start customizing and finish the flow.
  5. In the Assembler click on Add your logo.
  6. Upload a new logo and make sure the default width is 60px in the Image width selector and on the preview.
Screenshot 2024-03-07 at 14 01 49

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Set a default width for the site logo after uploading it.

Comment

@albarin albarin marked this pull request as ready for review March 7, 2024 13:04
@albarin albarin requested review from gigitux and nefeline March 7, 2024 13:04
@woocommercebot woocommercebot requested a review from a team March 7, 2024 13:06
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Hi @gigitux, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test Results Summary

Commit SHA: 6031b01

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 39s
E2E Tests279007203517m 35s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🚢

@albarin albarin merged commit 60d93e4 into trunk Mar 7, 2024
30 checks passed
@albarin albarin deleted the 45379-update-logo-width branch March 7, 2024 14:13
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 7, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 7, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 11, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
* Set default width after logo update

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on core] Update the default logo width
3 participants