New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from "invoice" to "order details" in our emails. #45395
Conversation
As was previously true, the email subject and header text can anyway be defined and overridden by the merchant (via the email settings screen). This change is really intended just to tweak the defaults, since use of 'invoice' is problematic in some contexts and geographies. |
Test Results SummaryCommit SHA: f608530
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
plugins/woocommerce/includes/emails/class-wc-email-customer-invoice.php
Outdated
Show resolved
Hide resolved
plugins/woocommerce/includes/emails/class-wc-email-customer-invoice.php
Outdated
Show resolved
Hide resolved
plugins/woocommerce/tests/e2e-pw/tests/merchant/order-emails.spec.js
Outdated
Show resolved
Hide resolved
Hi @jorgeatorres, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @barryhughes! Tests well.
Adding that I pushed a tiny commit to fix a typo in a docblock (f608530).
Thanks for this! |
Submission Review Guidelines:
Changes proposed in this Pull Request:
We refer to some of our order emails as 'invoices', which turns out to be problematic for some merchants/in some jurisdictions. This change drops the use of 'invoice', preferring 'order details' instead.
Some existing uses of 'invoice' remain in place (for instance, in relation to class and template names) to preserve backward compatibility and minimize disruption.
Closes #26692.
How to test the changes in this Pull Request:
Open an existing order for editing, and look at the order actions meta box (typically found in the top right of the screen). You should see an entry reading, "Send order details to customer." Previously, this read, "Email invoice / order details to customer."
Select the above option and click on Update. The email should be sent to the customer:
Details for order #1234 on My Site
(of course, the order number and site name will be different). Previously, it was eitherInvoice for order #1234 on My Site
orYour latest My Site invoice
(depending on order payment status).Details for order #1234
. Previously, it was eitherInvoice for order #1234
orYour invoice for order #1234
.Now visit WooCommerce ▸ Settings ▸ Emails. You should see an entry for the
Order details
email (previously was referred to asCustomer invoice / Order details
):Finally, consider clicking through via the above admin screen and modifying the settings for this email. Your changes should be reflected just as they would have been before this PR was written.
Changelog entry
Significance
Type
Message
Comment