Add Launch Your Store settings section #45402

moon0326 · 2024-03-07T21:17:35Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes #45107

This PR adds a new setting section for Launch Your Store site visibility under WooCommerce -> Settings -> General.

Things to do -- these items can be updated in a separate PR once the values and requirements are ready.

Add store pages link.
Add Editor link
Add Share your site with a private link feature.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Checkout this branch and enable launch-your-store feature flag.
Go to WooCommerce -> Settings
Confirm Site visibility section loads.
Change values and click on Save changes button.
Confirm the changes persist.

Changelog entry

Automatically create a changelog entry from the details below.

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Add Launch Your Store settings section

Comment

github-actions · 2024-03-07T21:17:54Z

Hi @adrianduffell, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

…mmerce

github-actions · 2024-03-07T21:25:59Z

Test Results Summary

Commit SHA: 438d631

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	332	0	0	19	0	351	7m 49s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

psealock

Thanks @moon0326 this is looking good.

There should be some consensus on the names of the options created here and the ones @chihsuan is creating in #45306. I like a combination of the two such as woocommerce_lys_coming_soon.

I'm also working on a UI component that makes use of these options and thought a useLaunchYourStore helper function would be useful. What do you think?

https://github.com/woocommerce/woocommerce/blob/7a988796839ca0fc7f6e3e0ce54ebec1ae810ab7/plugins/woocommerce-admin/client/header/launch-your-store/use-launch-your-store.js

I've got it in the header but its better suited to the folders you created here, plugins/woocommerce-admin/client/launch-your-store.

psealock · 2024-03-07T23:36:53Z

plugins/woocommerce-admin/client/settings/settings-slots.js

+		{
+			id: 'wc_settings_general_site_visibility_slotfill',
+			scope: 'woocommerce-site-visibility-settings',
+		},


Nice to see this getting used!

Nice! useLaunchYourStore looks fantastic! I'll update this PR to use it 👍

@psealock Could you also return comingSoon, storePagesOnly, privateLink, and shareKey from the function?

adrianduffell · 2024-03-08T00:38:59Z

Nice work on this @moon0326, I agree I think we just need to align on the names.

There should be some consensus on the names of the options created here and the ones @chihsuan is creating in #45306. I like a combination of the two such as woocommerce_lys_coming_soon.

I'll throw in a suggestion for:

woocommerce_coming_soon
woocommerce_coming_soon_store_pages_only
woocommerce_coming_soon_private_link

I think it might be better not to reference "Launch Your Store" in the option names. I see the site visibility / coming soon settings as a new platform feature for WooCommerce. The Launch Your Store task is just one feature that will utilize it. Potentially other features like CYS could make use of it in the future too.

moon0326 · 2024-03-08T00:58:45Z

@psealock @adrianduffell Updated option names in 48fdf30

@psealock I think we can update the code to use useLaunchYourStore in a follow-up PR. What do you think?

adrianduffell

Thanks @moon0326, this is great! With the updated option names it LGTM 🚀

I'll create new issues for the items you mentioned in the description.

Add store pages link.
Add Editor link
Add Share your site with a private link feature.

psealock

@psealock I think we can update the code to use useLaunchYourStore in a follow-up PR. What do you think?

Sounds good. Once this is merged I can move my compenent to the folder

psealock · 2024-03-08T02:25:29Z

plugins/woocommerce-admin/client/settings/settings-slots.js

@@ -18,6 +18,10 @@ export const possiblyRenderSettingsSlots = () => {
 		},
 		{ id: 'wc_tax_settings_slotfill', scope: 'woocommerce-tax-settings' },
 		{ id: 'wc_settings_slotfill', scope: 'woocommerce-settings' },
+		{
+			id: 'wc_settings_general_site_visibility_slotfill',
+			scope: 'woocommerce-site-visibility-settings',


I think we should use the same scope woocommerce-settings here. The reason this exists is so that we're not loading all of the app's Fills, just the ones that match the current scope. woocommerce-settings is already on the page so may as well use it

Sounds good @psealock 👍 Updated in Use woocommerce-settings scope

* Support div setting type * Add wc_settings_general_site_visibility_slotfill slotfill * Add site visibility setting section * Add placeholder * Rename div to slotfill_placeholder * Add comment * Fix component name * Add changefile(s) from automation for the following project(s): woocommerce * Use unique id * Rename option names * Put LYS settings behind launch-your-store flag * Move Site Visibility header to component * Lint fixes * Lint fixes * Use woocommerce-settings scope * lint fix --------- Co-authored-by: github-actions <github-actions@github.com>

moon0326 added 6 commits March 4, 2024 19:42

Support div setting type

708b7ef

Add wc_settings_general_site_visibility_slotfill slotfill

c48d121

Add site visibility setting section

193de0a

Add placeholder

d668bc0

Rename div to slotfill_placeholder

769b8ee

Add comment

28d1821

moon0326 requested review from a team, adrianduffell and rjchow March 7, 2024 21:17

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 7, 2024

moon0326 and others added 2 commits March 7, 2024 13:18

Fix component name

307913f

Add changefile(s) from automation for the following project(s): wooco…

f277d6b

…mmerce

Use unique id

44ac372

psealock reviewed Mar 7, 2024

View reviewed changes

Rename option names

48fdf30

adrianduffell approved these changes Mar 8, 2024

View reviewed changes

moon0326 added 2 commits March 7, 2024 17:27

Put LYS settings behind launch-your-store flag

7fd5be7

Move Site Visibility header to component

e4efc17

psealock approved these changes Mar 8, 2024

View reviewed changes

Lint fixes

bc20d56

psealock reviewed Mar 8, 2024

View reviewed changes

moon0326 added 3 commits March 7, 2024 18:29

Lint fixes

0558ed6

Use woocommerce-settings scope

01ff813

lint fix

dfcfa51

moon0326 enabled auto-merge (squash) March 8, 2024 03:42

Update test for slotfill_placeholder

438d631

moon0326 merged commit 1f914c7 into trunk Mar 8, 2024
33 checks passed

moon0326 deleted the add/45107-lys-settings-screen-page branch March 8, 2024 04:11

github-actions bot added this to the 8.8.0 milestone Mar 8, 2024

github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Launch Your Store settings section #45402

Add Launch Your Store settings section #45402

moon0326 commented Mar 7, 2024 •

edited

github-actions bot commented Mar 7, 2024

github-actions bot commented Mar 7, 2024 •

edited

psealock left a comment

psealock Mar 7, 2024

moon0326 Mar 8, 2024

moon0326 Mar 8, 2024

adrianduffell commented Mar 8, 2024

moon0326 commented Mar 8, 2024 •

edited

adrianduffell left a comment

psealock left a comment

psealock Mar 8, 2024

moon0326 Mar 8, 2024

Add Launch Your Store settings section #45402

Add Launch Your Store settings section #45402

Conversation

moon0326 commented Mar 7, 2024 • edited

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

github-actions bot commented Mar 7, 2024

github-actions bot commented Mar 7, 2024 • edited

Test Results Summary

psealock left a comment

Choose a reason for hiding this comment

psealock Mar 7, 2024

Choose a reason for hiding this comment

moon0326 Mar 8, 2024

Choose a reason for hiding this comment

moon0326 Mar 8, 2024

Choose a reason for hiding this comment

adrianduffell commented Mar 8, 2024

moon0326 commented Mar 8, 2024 • edited

adrianduffell left a comment

Choose a reason for hiding this comment

psealock left a comment

Choose a reason for hiding this comment

psealock Mar 8, 2024

Choose a reason for hiding this comment

moon0326 Mar 8, 2024

Choose a reason for hiding this comment

moon0326 commented Mar 7, 2024 •

edited

github-actions bot commented Mar 7, 2024 •

edited

moon0326 commented Mar 8, 2024 •

edited