[Experimental] Product Filter: Price (Beta) block: Prevent invalid price range selection in Product Filter Price block #45403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
thealexandrelara
added
type: bug
|
Hi @albarin, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: a802d17
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
dinhtungdu
approved these changes
Mar 8, 2024
Comment on lines
+84
to
+93
| // In some occasions the input element is updated with the incorrect value. | ||
| // By using the element that triggered the event, we can ensure the correct value is used for the input. | ||
| const element = getElement(); | ||
| if ( type === 'min' ) { | ||
| element.ref.value = currentMinPrice; | ||
| } | ||
|
|
||
| if ( type === 'max' ) { | ||
| element.ref.value = currentMaxPrice; | ||
| } |
| ) | ||
| : maxPrice; | ||
|
|
||
| // In some occasions the input element is updated with the incorrect value. |
There was a problem hiding this comment.
In my case, when the min and max price are equal, if I continue to move the max price to lower than the min price, the prices in the text inputs are correct, but the thumb doesn't return to the correct position.
thealexandrelara
deleted the
fix/45361-invalid-price-range-selection-in-product-filter-price-block
branch
github-actions
bot
added
the
needs: analysis
alopezari
added
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
…ice range selection in Product Filter Price block (#45403) * Prevent invalid price range selection in Product Filter Price block * Add changefile(s) from automation for the following project(s): woocommerce-blocks --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR adds checks to prevent shoppers from using invalid price range selections, such as selecting a minimum price that is higher than the max price. It also uses the
getElementmethod from the Interactivity API to get the element that triggered the update price event and force the correct value to be set to the input.Closes #45361.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/shop).Changelog entry
Significance
Type
Message
Fix an issue where shoppers could select invalid price ranges in the Product Filter: Price (Beta) block
Comment